Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: architecture determination in script #798

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

xavier-hou
Copy link
Member

Signed-off-by: hxcGit houxc_mail@163.com

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Use uname -m to view the machine architecture rather than arch and treate x86_64 as amd64.

Related Issues

#796

New Behavior (screenshots if needed)

In Linux machine

image

In MacOS

image

Signed-off-by: hxcGit <houxc_mail@163.com>
@xavier-hou
Copy link
Member Author

@cezhang Many thanks for your issue. #796 Warmly welcome to devstream!

Copy link
Member

@aFlyBird0 aFlyBird0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. 👏

@IronCore864 IronCore864 merged commit 079b152 into devstream-io:main Jul 4, 2022
@jxs1211
Copy link
Contributor

jxs1211 commented Jul 6, 2022

verified

@cezhang
Copy link
Contributor

cezhang commented Jul 6, 2022

It works on my machine. Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants