fix(gitlabcedocker): Improve the folder deletion logic in plugin gitl… #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-hutao
requested changes
Jun 30, 2022
|
Hi @LuckyDogg, thanks for your contribution! Please join CNCF's Slack, and join our channel in CNCF Slack!
|
|
DevStream community follows the conventional commits specification. Please read our doc and update your commit message. |
…ab-ce-docer Signed-off-by: luckyDogg <wilson.wang.hc@gmail.com> Signed-off-by: luckyDogg <wilson.wang.hc@gmail.com>
LuckyDogg
force-pushed
the
gitlabcedocker-fix
branch
from
365f563
to
5e14a62
Compare
daniel-hutao
approved these changes
Jun 30, 2022
IronCore864
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ab-ce-docer
Signed-off-by: luckyDogg wilson.wang.hc@gmail.com
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
this PR is a improvement for the folder deletion logic in plugin gitlab-ce-docer
Related Issues
#757
New Behavior (screenshots if needed)