Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ut):configloader ut #661 #751

Merged
merged 6 commits into from
Jun 24, 2022

Conversation

himku
Copy link
Contributor

@himku himku commented Jun 24, 2022

UT BBD.yaml

given:
  - name: "Config"                                  
    modules:
      - name: "LoadConfig"                    # 对于configloader.LoadConfig函数测试
        behavior:
          - when: "Yaml Parses Success"             
              - specify: "should state filed correctly"   # 是否应正确存档状态
               - should: "state.backend equal s3 or local"  # 应该是s3 or local
               - should: "state.options.statefile equal devstream.state"  # 应该是devstream.state

              - specify: "Tools Options cannot be empty"
               - should: "Array Tools not nil"
               - should: "Tools.Name not empty"
               - should: "Tools.InstanceID not empty"
               - should: "Tools.Options not empty"
               - should: "Tools.DependsOn not empty"
          - when: "Yaml Parses Fails"
             - specify: "Yaml parses fails"
               - should: "err not nil"

Description

Add configloader Loadconfig some ut test cases

Related Issues

🍀 Proposal: Add More ut to the configloader Package #661

New Behavior (screenshots if needed)

  • Correct configuration screenshots

image

  • Error configuration screenshots

image

IronCore864 and others added 6 commits June 24, 2022 15:46
Signed-off-by: Tiexin Guo <guotiexin@gmail.com>
Signed-off-by: sjie <baemawu@gmail.com>
Signed-off-by: xuwu <ixw1991@126.com>
Signed-off-by: sjie <baemawu@gmail.com>
Signed-off-by: xuwu <ixw1991@126.com>
Signed-off-by: sjie <baemawu@gmail.com>
Signed-off-by: Tiexin Guo <guotiexin@gmail.com>
Signed-off-by: sjie <baemawu@gmail.com>
Signed-off-by: sjie <baemawu@gmail.com>
@himku himku requested a review from a team as a code owner June 24, 2022 08:02
@IronCore864
Copy link
Member

@himku thanks for the contribution!

We will test your change locally and try to merge it as soon as possible.

Please join our Slack here. Feel free to reach out and request to join the contributor channel! We are also in CNCF now; please also consider joining this channel in CNCF Slack.

In the meantime, feel free to check out our new contributor guide. We have quite a few pieces of documentation explaining the basic concepts and how to work on DevStream. Read them in the "Developer Guide" section of the documentation.

If you are searching for something else to work on, please do check out the "find an issue" section. The "help wanted" label is an excellent place to continue. If you are not completely confident yet, maybe you can warm yourself up by solving another "good first issue".

Regarding commit messages, we try our best to follow the conventional commits specification so that it would give other people clear information. We've also got a "TL;DR" version in our documentation; feel free to have a quick glance. Please provide useful information in your commit message; and please do not use duplicated commit messages.

You do not need to update your commit messages for this PR. We will use squash merge and update the commit messages accordingly. Please try to follow the standard next time :)

@IronCore864 IronCore864 merged commit f167bf5 into devstream-io:main Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants