Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: build.zh.md, lint.zh.md chinese version, issue 710 #739

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

wendao365
Copy link
Contributor

@wendao365 wendao365 commented Jun 23, 2022

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Related Issues

close #710

New Behavior (screenshots if needed)

@aFlyBird0
Copy link
Member

Hi @wendao365

Thanks for your contribution! We will test your change locally and try to merge it as soon as possible.

Please join our Slack here. Feel free to reach out and request to join the contributor channel! We are also in CNCF now; please also consider joining this channel in CNCF Slack.

In the meantime, feel free to check out our new contributor guide. We have quite a few pieces of documentation explaining the basic concepts and how to work on DevStream. Read them in the "Developer Guide" section of the documentation.

If you are searching for something else to work on, please do check out the "find an issue" section. The "help wanted" label is an excellent place to continue. If you are not completely confident yet, maybe you can warm yourself up by solving another "good first issue".

@aFlyBird0
Copy link
Member

Your commit message follows conventional commits specification, I think it is great! 👍

@aFlyBird0
Copy link
Member

A kind reminder that you haven't signed off on your commit(s) yet.

Check out our official doc here to learn how to do this.

Licensing is important to open source projects. It provides some assurances that the software will continue to be available based on the terms that the author(s) desired.

Now that we are part of CNCF, per CNCF's requirement, we kindly require that contributors sign off on commits submitted to our project's repositories. Thanks!

@aFlyBird0
Copy link
Member

And little suggestions as below:
(You needn't do anything. I have helped you finish it) @wendao365

image

Copy link
Member

@aFlyBird0 aFlyBird0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, your translation is very good, and it is clear that you are translating from one sentence to another with care rather than simply using a machine translation.

Because of this, I would like to make this translation more perfect. So I hope I didn't offend you by making some suggestions.

docs/development/build.zh.md Outdated Show resolved Hide resolved
docs/development/build.zh.md Outdated Show resolved Hide resolved
docs/development/lint.zh.md Outdated Show resolved Hide resolved
docs/development/lint.zh.md Outdated Show resolved Hide resolved
@IronCore864
Copy link
Member

@aFlyBird0 please help the original contributor to merge this PR as soon as possible. We can squash and update the commit messages ourselves for first-time contributors.

Signed-off-by: wendao <1374968273@qq.com>
@aFlyBird0
Copy link
Member

Could you please review this pr? Thank you! @imxw

@IronCore864 IronCore864 merged commit 09b9c1e into devstream-io:main Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📖 Docs(Translation): Build & Lint - Chinese Version
3 participants