Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gitlab enhancement #621

Merged
merged 5 commits into from
May 30, 2022
Merged

feat: gitlab enhancement #621

merged 5 commits into from
May 30, 2022

Conversation

imxw
Copy link
Member

@imxw imxw commented May 26, 2022

Pre-Checklist

Description

  • Support Self-hosted gitlab by setting baseURL field
  • Support for creating a project under groups
  • Support specifying the visibility of the created project by setting visibility field

Related Issues

Closes #520

New Behavior (screenshots if needed)

image

image

@IronCore864
Copy link
Member

Tested locally for GitLab cloud:

tiexin@mbp ~/work/test/devstream $ ./dtm apply
2022-05-30 15:00:07 ℹ [INFO]  Apply started.
2022-05-30 15:00:07 ℹ [INFO]  Using dir <.devstream> to store plugins.
2022-05-30 15:00:07 ℹ [INFO]  Using local backend. State file: devstream.state.
2022-05-30 15:00:07 ℹ [INFO]  Tool (gitlab-repo-scaffolding-golang/default) found in config but doesn't exist in the state, will be created.
Continue? [y/n]
Enter a value (Default is n): y

2022-05-30 15:00:11 ℹ [INFO]  Start executing the plan.
2022-05-30 15:00:11 ℹ [INFO]  Changes count: 1.
2022-05-30 15:00:11 ℹ [INFO]  -------------------- [  Processing progress: 1/1.  ] --------------------
2022-05-30 15:00:11 ℹ [INFO]  Processing: (gitlab-repo-scaffolding-golang/default) -> Create ...
2022-05-30 15:00:15 ℹ [INFO]  The repo dtm-test-go has been created.
2022-05-30 15:00:17 ✔ [SUCCESS]  Tool (gitlab-repo-scaffolding-golang/default) Create done.
2022-05-30 15:00:17 ℹ [INFO]  -------------------- [  Processing done.  ] --------------------
2022-05-30 15:00:17 ✔ [SUCCESS]  All plugins applied successfully.
2022-05-30 15:00:17 ✔ [SUCCESS]  Apply finished.
tiexin@mbp ~/work/test/devstream $ ./dtm delete -y
2022-05-30 15:02:06 ℹ [INFO]  Delete started.
2022-05-30 15:02:06 ℹ [INFO]  Using dir <.devstream> to store plugins.
2022-05-30 15:02:07 ℹ [INFO]  Using local backend. State file: devstream.state.
2022-05-30 15:02:07 ℹ [INFO]  Tool (gitlab-repo-scaffolding-golang/default) will be deleted.
2022-05-30 15:02:07 ℹ [INFO]  Start executing the plan.
2022-05-30 15:02:07 ℹ [INFO]  Changes count: 1.
2022-05-30 15:02:07 ℹ [INFO]  -------------------- [  Processing progress: 1/1.  ] --------------------
2022-05-30 15:02:07 ℹ [INFO]  Processing: (gitlab-repo-scaffolding-golang/default) -> Delete ...
2022-05-30 15:02:08 ℹ [INFO]  Prepare to delete 'gitlab-repo-scaffolding-golang_default' from States.
2022-05-30 15:02:08 ✔ [SUCCESS]  Tool (gitlab-repo-scaffolding-golang/default) delete done.
2022-05-30 15:02:08 ℹ [INFO]  -------------------- [  Processing done.  ] --------------------
2022-05-30 15:02:08 ✔ [SUCCESS]  All plugins deleted successfully.
2022-05-30 15:02:08 ✔ [SUCCESS]  Delete finished.

Copy link
Member

@IronCore864 IronCore864 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made some commits to fix grammar issues in docs/comments/logs directly. Thanks for this great improvement @imxw.

@IronCore864 IronCore864 merged commit 9cd0838 into devstream-io:main May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🍀 Proposal: Plugin gitlab-repo-scaffolding-golang Enhancement (sub-task of #513)
2 participants