Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(configloader): varFile can be empty #572

Merged
merged 1 commit into from
May 21, 2022
Merged

fix(configloader): varFile can be empty #572

merged 1 commit into from
May 21, 2022

Conversation

aFlyBird0
Copy link
Member

Pre-Checklist

Description

In the previous version, varFile was mandatory, but it should actually be optional.

@aFlyBird0
Copy link
Member Author

LoadConf() will be Called every time which contains validateConfigFile().
bb86bceffb3d038b72ba451e33c93b8

Here are the core changes.

d9f099d79fddc2f709c5803e8bed599
image

daniel-hutao
daniel-hutao approved these changes May 21, 2022
View reviewed changes
Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Great Job！！！

@daniel-hutao daniel-hutao merged commit 1d52db0 into devstream-io:main May 21, 2022
@aFlyBird0 aFlyBird0 deleted the fix-config-varFile branch May 22, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-hutao daniel-hutao daniel-hutao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aFlyBird0 @daniel-hutao