Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support nested vars #1426

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Conversation

aFlyBird0
Copy link
Member

Signed-off-by: Bird aflybird0@gmail.com

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Support:

vars:
  a: [[ b]]a
  b: 123
  c: [[a]]c
  d: [[a]]/[[ c ]]/[[b]]

It is equal to:

vars:
  a: "123a"
  b: 123
  c: "123ac"
  d: "123a/123ac/123"

Related Issues

New Behavior (screenshots if needed)

@aFlyBird0 aFlyBird0 requested a review from a team as a code owner January 10, 2023 09:31
Signed-off-by: Bird <aflybird0@gmail.com>
Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Good unit tests!

@steinliber steinliber merged commit ded1004 into devstream-io:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants