Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: raise err when config env is not exist #1399

Merged

Conversation

steinliber
Copy link
Contributor

@steinliber steinliber commented Dec 28, 2022

Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • we use [[ env ENV_KEY ]] for the config option, for now, this pr will raise an exception when env value is not exist

Related Issues

#1211

New Behavior (screenshots if needed)

when env is not set
image

Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@daniel-hutao daniel-hutao removed their assignment Dec 29, 2022
@aFlyBird0 aFlyBird0 merged commit fd7e1b5 into devstream-io:main Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants