Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scm cant get repo name when use url #1353

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

steinliber
Copy link
Contributor

@steinliber steinliber commented Dec 16, 2022

Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • fix reposcaffolding in render variables when get repo name
  • fix repoInfo get name empty when use url

Related Issues

close #1352

New Behavior (screenshots if needed)

Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@steinliber steinliber requested a review from a team as a code owner December 16, 2022 06:18
@IronCore864 IronCore864 merged commit 617680e into devstream-io:main Dec 16, 2022
@IronCore864 IronCore864 deleted the fix-app-golang-error branch December 16, 2022 06:21
@steinliber steinliber mentioned this pull request Dec 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💣 Bug: golang reposcaffolding will not render file
3 participants