feat: check if the number of plugins on s3 is correct #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KeHaoKH <hao.ke@merico.dev>
Signed-off-by: KeHaoKH <hao.ke@merico.dev>
steinliber
approved these changes
Dec 9, 2022
daniel-hutao
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: KeHaoKH hao.ke@merico.dev
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
check if the number of plugins on s3 is correct.
By calculating the total number of local plugin files and comparing it with the total number of plugins in the corresponding directory of s3 (minus the number of dtm files for 3 platforms, i.e. 3), if they are not equal, an error message is returned after script execution.
New Behavior (screenshots if needed)
I took out the relevant pieces of logic in the script, named it a test script, and tested the results as follows: