Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support env vars #1279

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Conversation

aFlyBird0
Copy link
Member

@aFlyBird0 aFlyBird0 commented Nov 30, 2022

Signed-off-by: Bird aflybird0@gmail.com

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

before:

token1: [[ env GITHUB_TOKEN]]
token2: [[ env "GITLAB_TOKEN" ]]

rendered:

token1: token_value_xxx
token2: token_value_xxx

Related Issues

New Behavior (screenshots if needed)

@aFlyBird0 aFlyBird0 requested a review from a team as a code owner November 30, 2022 08:32
@aFlyBird0 aFlyBird0 force-pushed the feat-env-var branch 3 times, most recently from 40c2241 to db20e1e Compare November 30, 2022 08:39
Signed-off-by: Bird <aflybird0@gmail.com>
Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good unit tests!

@daniel-hutao daniel-hutao merged commit 9fa5445 into devstream-io:main Dec 1, 2022
@aFlyBird0 aFlyBird0 deleted the feat-env-var branch December 12, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants