Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reposcaffolding raise error when variable not exist #1263

Merged

Conversation

steinliber
Copy link
Contributor

@steinliber steinliber commented Nov 28, 2022

Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • raise error when repoTemplate variable not exist
  • kubectl does'nt rase error when error

Related Issues

close #1262

New Behavior (screenshots if needed)

@steinliber steinliber requested a review from a team as a code owner November 28, 2022 06:07
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@IronCore864 IronCore864 merged commit 54576cb into devstream-io:main Nov 28, 2022
@IronCore864 IronCore864 deleted the fix-configmanager-log-error branch November 28, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💣 Bug: repoScaffolding not render variables
3 participants