Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make SetPluginDir function more clear #1206

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

daniel-hutao
Copy link
Member

Signed-off-by: Daniel Hu tao.hu@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

chore: make SetPluginDir function more clear

Related Issues

N/A

New Behavior (screenshots if needed)

N/A

Signed-off-by: Daniel Hu <tao.hu@merico.dev>
Copy link
Member

@iyear iyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-hutao daniel-hutao merged commit 030bd2f into devstream-io:main Oct 28, 2022
@daniel-hutao daniel-hutao deleted the feat-install branch October 28, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants