Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reposcaffold not valid for orgization #1184

Merged

Conversation

steinliber
Copy link
Contributor

@steinliber steinliber commented Oct 17, 2022

Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • fix reposcaffolding error when use org
  • fix e2e test error

Related Issues

close #1183

New Behavior (screenshots if needed)

@steinliber steinliber requested a review from a team as a code owner October 17, 2022 13:16
Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also delete the "unused" comment above the GetRepoOwner() method in this pr?

// unused
func (r *RepoInfo) GetRepoOwner() string {
	if r.Org != "" {
		return r.Org
	}
	return r.Owner
}

Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@steinliber steinliber force-pushed the fix-reposcaffolding-owner-field branch from 448746e to c8518b9 Compare October 17, 2022 14:29
@steinliber
Copy link
Contributor Author

Could you please also delete the "unused" comment above the GetRepoOwner() method in this pr?

// unused
func (r *RepoInfo) GetRepoOwner() string {
	if r.Org != "" {
		return r.Org
	}
	return r.Owner
}

Fixed

@daniel-hutao daniel-hutao merged commit c81ae2a into devstream-io:main Oct 17, 2022
@daniel-hutao daniel-hutao deleted the fix-reposcaffolding-owner-field branch October 17, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💣 Bug: Reposcaffolding not support org field
3 participants