Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ci plugin support update when ci file change #1168

Merged
merged 3 commits into from
Oct 12, 2022
Merged

feat: ci plugin support update when ci file change #1168

merged 3 commits into from
Oct 12, 2022

Conversation

steinliber
Copy link
Contributor

@steinliber steinliber commented Oct 11, 2022 •
edited
Loading

Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • ci plugin will update file in scm when ci files change
  • rename scm client method for better understandable
  • move ci server related code to server module

Related Issues

close #1161

New Behavior (screenshots if needed)

@steinliber steinliber requested a review from a team as a code owner October 11, 2022 14:20
@steinliber
feat: ci support update when ci file change
9465bd9 
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
iyear
iyear reviewed Oct 11, 2022
View reviewed changes
pkg/util/scm/git/state.go Outdated Show resolved Hide resolved
iyear
iyear approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@iyear iyear left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am not familar with gitlab library, so I only reviewed the basic logic.

@aFlyBird0 aFlyBird0 self-assigned this Oct 11, 2022
@aFlyBird0 aFlyBird0 self-requested a review October 11, 2022 15:19
@daniel-hutao daniel-hutao removed the request for review from aFlyBird0 October 12, 2022 01:37
@steinliber
feat: use md5 for local file has
3aaea29 
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
aFlyBird0
aFlyBird0 reviewed Oct 12, 2022
View reviewed changes
internal/pkg/plugininstaller/ci/installer.go Outdated Show resolved Hide resolved
internal/pkg/plugininstaller/ci/option.go Show resolved Hide resolved
internal/pkg/plugininstaller/ci/server/server.go Outdated Show resolved Hide resolved
internal/pkg/plugininstaller/ci/server/server.go Outdated Show resolved Hide resolved
@steinliber
fix: comment error
8319977 
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
aFlyBird0
aFlyBird0 approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@aFlyBird0 aFlyBird0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steinliber steinliber merged commit 4769329 into devstream-io:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyear iyear iyear approved these changes

@aFlyBird0 aFlyBird0 aFlyBird0 approved these changes

@IronCore864 IronCore864 Awaiting requested review from IronCore864

Assignees

@IronCore864 IronCore864

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🍀 Proposal: update plugin when ci files changed
4 participants
@steinliber @aFlyBird0 @iyear @IronCore864