fix: avoid flag name colision in viper #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algobot76
force-pushed
the
viper-workaround
branch
from
1dc44d9
to
ea99809
Compare
|
@algobot76 Thanks for your contribution. Please see my comment in #1140 (comment). cc @IronCore864 |
IronCore864
approved these changes
Oct 10, 2022
|
Great stuff! Need another review here @devstream-io/devstream |
|
Some code cleanup is needed. Convert this pr to draft for now, and will reopen it later this week. |
algobot76
force-pushed
the
viper-workaround
branch
2 times, most recently
from
ed83163
to
62b8d17
Compare
Signed-off-by: Kaitian Xie <kaitian96@outlook.com>
algobot76
force-pushed
the
viper-workaround
branch
from
62b8d17
to
be877d9
Compare
Additional comments on this issue have been added. Please take a look. |
steinliber
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kaitian Xie kaitian96@outlook.com
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
a workaround for a known bug in Viper: spf13/viper#233
Related Issues
Close #1140
New Behavior (screenshots if needed)
Now it works as expected