Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jenkins pipeline support image repo variable #1061

Conversation

steinliber
Copy link
Contributor

@steinliber steinliber commented Sep 4, 2022

Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • jenkins-pipeline plugin support Harbor variable
  • fix Gitlab silent error

Related Issues

#993

New Behavior (screenshots if needed)

image

Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@steinliber steinliber requested a review from a team as a code owner September 4, 2022 16:22
Copy link
Member

@iyear iyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👏

Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@steinliber steinliber changed the title feat: jenkins pipeline support harbor variable feat: jenkins pipeline support image repo variable Sep 5, 2022
@daniel-hutao daniel-hutao merged commit 8ef7575 into devstream-io:main Sep 5, 2022
@daniel-hutao daniel-hutao deleted the feat-jenkins-pipeline-support-harbor branch September 5, 2022 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants