Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🍀 Proposal: pkg/util Enhancement #833

Closed
jxs1211 opened this issue Jul 11, 2022 · 3 comments
Closed

🍀 Proposal: pkg/util Enhancement #833

jxs1211 opened this issue Jul 11, 2022 · 3 comments
Assignees
@jxs1211
Labels
help wanted Extra attention is needed test ut & e2e & ...

Comments

@jxs1211
Copy link
Contributor

jxs1211 commented Jul 11, 2022

What Would You Like to Add? Why Is This Needed?

After some code investigation, I found there are many plugins depend on the pkg/util, so I suppose it is quite important to make the package more solid, and the way to improve it is various:

  • better naming
  • better code organization
  • refactor to make it easier to test
  • ut
  • other aspect to make it stronger

Design

The tools in this directory have been divided into categories, like downloader\gitlab\github\k8s\helm, etc. So we could refactor it one by one, and create some sub task under this proposal,his could help us move faster and more stable.

Anything else
@jxs1211
Copy link
Contributor Author

jxs1211 commented Jul 11, 2022

@HXCGIT pls do me a favor to label this proposal with helpwant,refactor,enhancement,test

@xavier-hou
Copy link
Member

@jxs1211 That's right. I think the best way to start this job is to add some unit tests. Care to contribute some PR for it?

@xavier-hou xavier-hou added help wanted Extra attention is needed test ut & e2e & ... labels Jul 11, 2022
@jxs1211
Copy link
Contributor Author

jxs1211 commented Jul 12, 2022

@HXCGIT Maybe we could add some sub task to do this

@jxs1211 jxs1211 mentioned this issue Jul 12, 2022
Closed
jxs1211 added a commit to jxs1211/devstream that referenced this issue Jul 12, 2022
@jxs1211
feat: pkg/util/helm Enhancement (sub task of pkg/util Enhancement dev…
b97f48a 
…stream-io#833) devstream-io#838

Signed-off-by: xian-jie.shen <327411586@qq.com>
@jxs1211 jxs1211 mentioned this issue Jul 12, 2022
Merged
3 tasks
jxs1211 added a commit to jxs1211/devstream that referenced this issue Jul 13, 2022
@jxs1211
feat: pkg/util/helm Enhancement (sub task of pkg/util Enhancement dev…
4fc3ce1 
…stream-io#833) devstream-io#838

Signed-off-by: xian-jie.shen <327411586@qq.com>
jxs1211 added a commit to jxs1211/devstream that referenced this issue Jul 13, 2022
@jxs1211
feat: pkg/util/helm Enhancement (sub task of pkg/util Enhancement dev…
f388c59 
…stream-io#833) devstream-io#838

Signed-off-by: xian-jie.shen <327411586@qq.com>
jxs1211 added a commit to jxs1211/devstream that referenced this issue Jul 14, 2022
@jxs1211
feat: pkg/util/helm Enhancement (sub task of pkg/util Enhancement dev…
2997bb6 
…stream-io#833) devstream-io#838

Signed-off-by: xian-jie.shen <327411586@qq.com>
jxs1211 added a commit to jxs1211/devstream that referenced this issue Jul 15, 2022
@jxs1211
feat: pkg/util/helm Enhancement (sub task of pkg/util Enhancement dev…
8dc529e 
…stream-io#833) devstream-io#838

Signed-off-by: xian-jie.shen <327411586@qq.com>
This was referenced Jul 15, 2022
Merged
Merged
Merged
jxs1211 added a commit to jxs1211/devstream that referenced this issue Jul 17, 2022
@jxs1211
feat: pkg/util/log Enhancement (sub task of pkg/util Enhancement devs…
4325136 
…tream-io#833)

Signed-off-by: xian-jie.shen <327411586@qq.com>
This was referenced Jul 17, 2022
Merged
Merged
Merged
xavier-hou added a commit that referenced this issue Jul 18, 2022
@xavier-hou
Merge pull request #856 from jxs1211/feat-pkg-util-md5
d6875bb 
🍀 Proposal: pkg/util/md5 Enhancement (sub task of pkg/util Enhancement #833)
@iyear iyear mentioned this issue Jul 18, 2022
Closed
10 tasks
@jxs1211 jxs1211 mentioned this issue Jul 19, 2022
Merged
3 tasks
xavier-hou added a commit that referenced this issue Jul 19, 2022
@xavier-hou
Merge pull request #858 from jxs1211/feat-pkg-util-log
b0364a5 
feat: pkg/util/log Enhancement (sub task of pkg/util Enhancement #833)
xavier-hou added a commit that referenced this issue Jul 20, 2022
@xavier-hou
Merge pull request #854 from jxs1211/perf-improvement
3b49ab4 
perf: pkg/util/mapz Enhancement (sub task of pkg/util Enhancement #833)
xavier-hou added a commit that referenced this issue Jul 21, 2022
@xavier-hou
Merge pull request #869 from jxs1211/feat-pkg-util-gitlab
1adf10f 
feat: pkg/util/gitlab Enhancement (sub task of pkg/util Enhancement #833)
This was referenced Jul 22, 2022
Merged
Merged
This was referenced Jul 23, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jxs1211 jxs1211

Labels
help wanted Extra attention is needed test ut & e2e & ...
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jxs1211 @steinliber @xavier-hou