Feature/jsonapi relationships #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(missing/test failing relationships of relationships and unify included relationships)
Current coverage is 98.10%@@ master #66 diff @@
==========================================
Files 6 6
Lines 318 369 +51
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 314 362 +48
- Misses 4 7 +3
Partials 0 0
|
# Conflicts: # Source/JSONAPISerializer.swift
| @@ -19,6 +19,15 @@ public protocol JSONAPISerializable { | |||
| - returns: Return an object representing the `data` field conforming to JSON API, for `JSONAPIEntity` boxes the return type will be used to fill the `relationships` field otherwise, when nil, the box will be serialized normally and used for the `attributes` field. | |||
| */ | |||
| func data(includeRelationships includeRelationships: Bool, includeAttributes: Bool) -> AnyObject? | |||
|
|
|||
| /** | |||
| Creates the `included` field by aggregating and unifying the attrbiutes of the relationships recursively | |||
Feature/jsonapi links
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55