Add PATCH support #134
Add PATCH support #134
Conversation
Generated by 🚫 danger |
Current coverage is 99.58% (diff: 100%)@@ master #134 diff @@
==========================================
Files 10 10
Lines 479 481 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 477 479 +2
Misses 2 2
Partials 0 0
|
|
Also fine for me as soon as you fix the indentation issues. Special kudos for adding the unit test and keep the coverage up to date 👍 |
|
@MP0w @joanromano updated 👍 , thanks. |
| @@ -283,10 +284,31 @@ public final class Router { | |||
| public func post(_ path: String, handler: @escaping RouteHandler) { | |||
| addRoute(with: path, method: .post, handler: handler) | |||
| } | |||
|
|
|||
|
|
|||
| /** | |||
There was a problem hiding this comment.
oh apparently all of this is still shifted
There was a problem hiding this comment.
| - parameter handler: A `RouteHandler` handler that will be used when the route is matched for a GET request | ||
| */ | ||
| public func patch(_ path: String, handler: @escaping RouteHandler) { | ||
| addRoute(with: path, method: .patch, handler: handler) |
There was a problem hiding this comment.
and this line still has a tab I guess
|
Sublime to the rescue 🙏 |
| @@ -118,6 +118,7 @@ public final class Router { | |||
| case post = "POST" | |||
| case put = "PUT" | |||
| case delete = "DELETE" | |||
| case patch = "PATCH" | |||
There was a problem hiding this comment.
@joanromano I think we misuse the review... you add comments but people won't see it until you "finish" the review with one of the options (comment, approve, decline)...
so we couldn't see your comments until you approved 👎
There was a problem hiding this comment.
FYI I think I did the same mistake before
There was a problem hiding this comment.
oh, my bad then 😞 Sorry if that confused you @hernangonzalez
| URLSession.shared.dataTask(with: request) { (_, _, _) in }.resume() | ||
|
|
||
| expect(calledPatch).toEventually(beTrue()) | ||
| } |
There was a problem hiding this comment.
Also in this file indentations are wrong, could you please fix them?
There was a problem hiding this comment.
ty, let's just wait for ci and I will merge 🎉
https://www.youtube.com/watch?v=SsoOG6ZeyUI :)
|
Travis has issues with macOS today, builds are delayed |
Hi,
Added support to PATCH methods that I use in my projects. Let me know if anything needs a change.
Thanks,
H.