Fix transitive contentFiles support that's missing in nuget #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So, turns out that nuget is completely broken for transitive assets that aren't specifically `buildTransitive` assets. Why that scenario was fixed just for that ultra-narrow use case of build assets is anyone's guess. So, we leverage that one-and-only working transitive scenario to detect the situation where transitive assets are missing (the Compile files we provide as content) and include the missing files ourselves. This requires changing the way we allow opt-out of the service attribute type, though, since now there is no package reference to set the Exclude on. For that, we provide a new property IncludeServiceAttribute that we use to remove the automatically added contentFiles (in non-transitive) or skip adding ourselves (in transitive). Fixes #8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, turns out that nuget is completely broken for transitive assets that aren't specifically
buildTransitiveassets. Why that scenario was fixed just for that ultra-narrow use case of build assets is anyone's guess.So, we leverage that one-and-only working transitive scenario to detect the situation where transitive assets are missing (the Compile files we provide as content) and include the missing files ourselves.
This requires changing the way we allow opt-out of the service attribute type, though, since now there is no package reference to set the Exclude on. For that, we provide a new property IncludeServiceAttribute that we use to remove the automatically added contentFiles (in non-transitive) or skip adding ourselves (in transitive).
Fixes #8