Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix POLL* definitions per Dolphin #73

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Conversation

endrift
Copy link
Contributor

@endrift endrift commented Feb 10, 2020

Cf. https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/Core/IOS/Network/IP/Top.cpp#L608-L609
These #defines don't affect lwip/GC networking at all. The POLLIN mask is defined per POSIX:

[The POLLIN] flag shall be equivalent to POLLRDNORM | POLLRDBAND.

@mtheall
Copy link

mtheall commented Feb 21, 2020

I don't buy that this "don't affect lwip/GC networking at all." Aren't these the flags that you would plug into pollsd::events/revents? I would be more convinced if you showed evidence that the current flags are wrong when running on hardware.

The note about POSIX seems like a red herring. Is it expected that the official library strictly adheres to POSIX?

@endrift
Copy link
Contributor Author

endrift commented Feb 21, 2020

The reason it doesn't affect lwip is because lwip doesn't implement net_poll: https://github.com/devkitPro/libogc/search?q=net_poll&unscoped_q=net_poll

@WinterMute WinterMute merged commit 5fa1efd into devkitPro:master Mar 3, 2020
WinterMute pushed a commit that referenced this pull request Apr 19, 2020
@endrift endrift deleted the poll-enum branch April 19, 2020 03:57
Extrems pushed a commit to extremscorner/libogc-rice that referenced this pull request Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants