Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aes: add code to encrypt/decrypt using the aes engine #132

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

DacoTaco
Copy link
Member

@DacoTaco DacoTaco commented Dec 5, 2022

@GaryOderNichts since it is mostly your code, feel free to review the changes in libogc to support the aes engine through /dev/aes

ill merge it when you accept the changes to your code

Copy link

@GaryOderNichts GaryOderNichts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this into a PR. Left some comments on the code.
Also you should probably convert everything to tabs instead of spaces for consistency with the rest of libogc, I think discord turned it into spaces.

gc/ogc/aes.h Outdated Show resolved Hide resolved
libogc/aes.c Outdated Show resolved Hide resolved
libogc/aes.c Show resolved Hide resolved
libogc/aes.c Outdated Show resolved Hide resolved
libogc/aes.c Outdated Show resolved Hide resolved
libogc/aes.c Outdated Show resolved Hide resolved
libogc/aes.c Show resolved Hide resolved
@DacoTaco
Copy link
Member Author

DacoTaco commented Dec 6, 2022

huh, i didn't notice the spaces before.
fixed it, together with your other remarks

Copy link

@GaryOderNichts GaryOderNichts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AES_BLOCK_SIZE is still defined in both files. Can probably be removed from the .c.
Looks good otherwise 👍

@DacoTaco DacoTaco merged commit 7e37e62 into devkitPro:master Dec 6, 2022
@DacoTaco DacoTaco deleted the feature/AesEngine branch December 6, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants