Add argument parameter for AESND callbacks

[HTV04]

Adds an argument parameter for AESND's audio and voice callbacks. This allows these static functions to have a pointer to data passed over when called, for example, a pointer to a C++ class instance.

[eku]

Did you check if this breaks existing homebrew projects?

[WinterMute]

It's a hard call tbh. I can see the utility of your change but of course this means that the ABI gets broken & old projects that use this interface need updated accordingly.

What I'd suggest is perhaps updating AESND_RegisterVoiceCallback to set the arg to NULL & adding a new function which takes the argument (i.e. AESND_RegisterVoiceCallbackWithArg) instead.

[DacoTaco]

What I'd suggest is perhaps updating AESND_RegisterVoiceCallback to set the arg to NULL & adding a new function which takes the argument (i.e. AESND_RegisterVoiceCallbackWithArg) instead.

i was looking at this yesterday before going to bed and i was thinking the same. this would make it not break for existing projects. C equivalent of a function overload (aka a new function with a different name in C haha)

[HTV04]

It's a hard call tbh. I can see the utility of your change but of course this means that the ABI gets broken & old projects that use this interface need updated accordingly.

What I'd suggest is perhaps updating AESND_RegisterVoiceCallback to set the arg to NULL & adding a new function which takes the argument (i.e. AESND_RegisterVoiceCallbackWithArg) instead.

Done

[WinterMute]

These changes will mean code using the old API will emit a single call to the new API instead of a double call.

[HTV04]

I moved the 3 non-WithArg functions to aesndlib.h and made them static inline as requested.

[HTV04]

Not to sound impatient, but is there anything else I should change for my PR? GitHub still says "changes requested," but I think I have made all of the requested changes.

[DacoTaco]

Not to sound impatient, but is there anything else I should change for my PR? GitHub still says "changes requested," but I think I have made all of the requested changes.

sorry for the waiting. ive been a bit busy.
the comments that request changes have not been marked as resolved, despite being resolved ( i think ). in a PR somebody (either the author of the PR or the reviewer) should mark comments as resolved when they are resolved, it doesn't happen automatically.

ill leave this page open on my pc and take a look at this tonight :)

[DacoTaco]

there, merged.

thanks for the PR @HTV04
sorry it took so long

[HTV04]

there, merged.

thanks for the PR @HTV04 sorry it took so long

No problem, thanks for merging it!