Skip to content

Commit

Permalink
gx: use correct constant name for PASSCLR operation (#176)
Browse files Browse the repository at this point in the history
In the alpha input we should use only GX_CA_* registers.  Both GX_CC_A2
and GX_CA_ZERO evaluate to 7, so this is just a cosmetic issue.

The existing error is probably the result of a misunderstanding during
reverse engineering.
  • Loading branch information
mardy committed Jun 23, 2024
1 parent 4719126 commit 0d23455
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion libogc/gx.c
Original file line number Diff line number Diff line change
Expand Up @@ -3858,7 +3858,7 @@ void GX_SetTevOp(u8 tevstage,u8 mode)
break;
case GX_PASSCLR:
GX_SetTevColorIn(tevstage,GX_CC_ZERO,GX_CC_ZERO,GX_CC_ZERO,defcolor);
GX_SetTevAlphaIn(tevstage,GX_CC_A2,GX_CC_A2,GX_CC_A2,defalpha);
GX_SetTevAlphaIn(tevstage,GX_CA_ZERO,GX_CA_ZERO,GX_CA_ZERO,defalpha);
break;
}
GX_SetTevColorOp(tevstage,GX_TEV_ADD,GX_TB_ZERO,GX_CS_SCALE_1,GX_TRUE,GX_TEVPREV);
Expand Down

0 comments on commit 0d23455

Please sign in to comment.