Feat/4.14.1 (#139)

* 4.14.1 * 4.14.1
dev-ptera · Mar 21, 2024 · 41f4bc4 · 41f4bc4
1 parent 8db96d8
commit 41f4bc4
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Change Log
 
+## v4.14.1 (March 20, 2024)
+
+### Fixed
+
+-  Adds a check when receiving transactions, enforce that balance increases.  
+
 ## v4.14.0 (March 16, 2024)
 
 ### Changed

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "thebananostand",
-  "version": "4.14.0",
+  "version": "4.14.1",
   "scripts": {
     "ng": "ng",
     "start": "ng serve --open --host 0.0.0.0",

diff --git a/src/app/services/rpc.service.ts b/src/app/services/rpc.service.ts
@@ -40,6 +40,7 @@ export class RpcService {
     }
 
     /** Returns array of receivable transactions, sorted by balance descending. */
+    // TODO: Use this instead of Spyglass API receivable call.
     async getReceivable(address: string): Promise<ReceivableHash[]> {
         const MAX_PENDING = 100;
         const threshold = this._util.convertBanToRaw(this._appStateService.store.getValue().minimumBananoThreshold);

diff --git a/src/app/services/transaction.service.ts b/src/app/services/transaction.service.ts
@@ -7,6 +7,7 @@ import { PowService } from '@app/services/pow.service';
 import { AccountOverview } from '@app/types/AccountOverview';
 import { TransactionBlock } from '@app/types/TransactionBlock';
 import { ReceivableTx } from '@app/types/ReceivableTx';
+import { UtilService } from '@app/services/util.service';
 
 type BananoifiedWindow = {
     bananocoinBananojs: any;
@@ -57,7 +58,8 @@ export class TransactionService {
         private readonly _signerService: SignerService,
         private readonly _datasource: DatasourceService,
         private readonly _appStateService: AppStateService,
-        private readonly _rpcService: RpcService
+        private readonly _rpcService: RpcService,
+        private readonly _util: UtilService
     ) {}
 
     private async _configApi(bananodeApi): Promise<void> {
@@ -178,6 +180,13 @@ export class TransactionService {
         const valueRaw = (BigInt(incoming.amountRaw) + BigInt(accountBalanceRaw)).toString();
         const isOpeningAccount = !accountInfo.representative;
 
+        const beforeTxBan = this._util.convertRawToBan(accountBalanceRaw);
+        const afterTxBan = this._util.convertRawToBan(valueRaw);
+        if (afterTxBan < beforeTxBan) {
+            console.error('Receivable block lowers account balance, rejecting block.', beforeTxBan, afterTxBan);
+            return undefined;
+        }
+
         // TODO - Get this from the rep list, top rep please.
         const representative = isOpeningAccount
             ? 'ban_3batmanuenphd7osrez9c45b3uqw9d9u81ne8xa6m43e1py56y9p48ap69zg'