build(deps): bump ibc-go to v3.0.0 and wasmd to v0.27.0 #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated cosmos-sdk-fork dep to v0.45.4
…s into leonardo/update-wasmd-dep-0.27.0 � Conflicts: � go.mod � go.sum
updated wasmd to v0.27.0
github-actions
bot
added
kind/build
leobragaz
added
dependencies
github-actions
bot
added
kind/build
updated cosmos-fork dependency
leobragaz
added
cosmwasm
RiccardoM
approved these changes
May 26, 2022
RiccardoM
changed the title
…update-wasmd-dep-0.27.0 � Conflicts: � go.mod � go.sum
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
github-actions
bot
added
kind/build
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #875 +/- ##
==========================================
+ Coverage 81.76% 81.77% +0.01%
==========================================
Files 110 110
Lines 9240 9248 +8
==========================================
+ Hits 7555 7563 +8
Misses 1363 1363
Partials 322 322
Continue to review full report at Codecov.
|
dadamu
reviewed
May 27, 2022
app/app.go
Outdated
| @@ -536,7 +544,8 @@ func NewDesmosApp( | |||
| ) | |||
|
|
|||
| // Add wasm module route to the ibc router, then set and seal it | |||
| ibcRouter.AddRoute(wasm.ModuleName, wasm.NewIBCHandler(app.WasmKeeper, app.IBCKeeper.ChannelKeeper)) | |||
| // TODO re-add this in a further PR to update wasmd | |||
There was a problem hiding this comment.
Shouldn't it be re-added since this PR also includes the wasmd updation?
There was a problem hiding this comment.
@dadamu Added back, thanks!
…update-wasmd-dep-0.27.0
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
dadamu
reviewed
May 27, 2022
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
dadamu
reviewed
May 30, 2022
| @@ -35,7 +35,7 @@ func NewCoordinator(t *testing.T, n int) *Coordinator { | |||
| chains := make(map[string]*TestChain) | |||
|
|
|||
| for i := 0; i < n; i++ { | |||
| chainID := GetChainID(i) | |||
| chainID := GetChainID(i + 1) | |||
There was a problem hiding this comment.
This is just to reflect the following change that has been made inside the standard Coordinator implementation with ibc-go v3.0.0:
(testing) cosmos/ibc-go#774 Added ChainID arg to SetupWithGenesisValSet on the testing app. Coordinator generated ChainIDs now starts at index 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Superseeds #874
Closes: #872
Closes: #873
Bumps wasmd to v0.27.0
Includes also the changes of #874 since the two are strictly dependent.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change