-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: release v5.0.0 #1131
chore!: release v5.0.0 #1131
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1131 +/- ##
==========================================
+ Coverage 80.69% 80.87% +0.17%
==========================================
Files 189 187 -2
Lines 16854 16797 -57
==========================================
- Hits 13601 13584 -17
+ Misses 2657 2617 -40
Partials 596 596
☔ View full report in Codecov by Sentry. |
The genesis file is using github Lfs, we need to revert this change to fix chain upgrade test: |
I notice the "gov" module state of exported genesis file has cosmos SDK 0.47.0 feature, maybe you use the wrong desmos version to export the genesis file. |
1288ffb
to
cab0f3b
Compare
The error happens since I fixed the issue by this commit, please go ahead if you feel it is good enough: In addition, I added the missing storekey |
@dadamu I should have already taken care of that issue with b5d66c6, which is already on this branch. No need to edit the Makefile when we can simply edit the For the other changes, I'll include them in a future commit. Update - 05/05/2023 16:00 UTC
I honestly don't undestand what has changed to bring this issue up. Update - 05/05/2023 17:00 UTC Update - 05/05/2023 19:30 UTC |
@@ -384,7 +384,7 @@ build-docker-desmosnode: | |||
# Setups 4 folders representing each one the genesis state of a testnet node | |||
setup-localnet: build-linux | |||
if ! [ -f build/node0/desmos/config/genesis.json ]; then $(BUILDDIR)/desmos testnet \ | |||
-o ./build --starting-ip-address 192.168.10.2 --keyring-backend=test \ | |||
-o ./build --starting-ip-address 192.168.255.2 --keyring-backend=test \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change, as well as other IP-related changes, were made in order to avoid any conflict if developers are connected to a nertwork that uses subnet 192.168.10.0
.
@@ -14,7 +14,7 @@ require ( | |||
github.com/cosmos/cosmos-proto v1.0.0-beta.2 | |||
github.com/cosmos/cosmos-sdk v0.47.2 | |||
github.com/cosmos/go-bip39 v1.0.0 | |||
github.com/cosmos/gogoproto v1.4.10 | |||
github.com/cosmos/gogoproto v1.4.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is done in order to avoid the following errors when running the desmos query
command:
WARNING: proto: file name query.proto does not start with expected testdata/; please make sure your folder structure matches the proto files fully-qualified names
WARNING: proto: file name testdata.proto does not start with expected testdata/; please make sure your folder structure matches the proto files fully-qualified names
WARNING: proto: file name tx.proto does not start with expected testdata/; please make sure your folder structure matches the proto files fully-qualified names
WARNING: proto: file name unknonwnproto.proto does not start with expected testdata/; please make sure your folder structure matches the proto files fully-qualified names
This is caused by how the Protobuf generation is setup inside Cosmos SDK. See here.
… running commands
Co-authored-by: Paul Chen <p22626262@gmail.com>
Description
This PR prepares the Desmos Core codebase for the
v5.0.0
release.To do this, the following changes have been made:
github.com/desmos-labs/desmos/v5
v5.0.0
upgrade handlerCHANGELOG.md
file with the new changesDepends-On: #1132
Depends-On: #1133
DCD-348
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change