Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: release v5.0.0 #1131

Merged
merged 27 commits into from
May 16, 2023
Merged

chore!: release v5.0.0 #1131

merged 27 commits into from
May 16, 2023

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented May 3, 2023

Description

This PR prepares the Desmos Core codebase for the v5.0.0 release.

To do this, the following changes have been made:

  1. bump the Go package name to github.com/desmos-labs/desmos/v5
  2. update the on-chain upgrade workflow to test the v5.0.0 upgrade handler
  3. updated the CHANGELOG.md file with the new changes
  4. deleted all the changeset entries

Depends-On: #1132
Depends-On: #1133

DCD-348


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@RiccardoM RiccardoM added the requires-upgrade Test the on-chain upgrade for this PR label May 3, 2023
@RiccardoM RiccardoM requested a review from a team as a code owner May 3, 2023 18:54
@github-actions github-actions bot added kind/build Related to the build of the project kind/ci Improve the CI/CD x/CLI x/fees x/profiles Module that allows to create and manage decentralized social profiles x/relationships x/subspaces Issue on the x/subspaces module labels May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.17 🎉

Comparison is base (c2ebd46) 80.69% compared to head (5b90707) 80.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1131      +/-   ##
==========================================
+ Coverage   80.69%   80.87%   +0.17%     
==========================================
  Files         189      187       -2     
  Lines       16854    16797      -57     
==========================================
- Hits        13601    13584      -17     
+ Misses       2657     2617      -40     
  Partials      596      596              
Impacted Files Coverage Δ
app/ante.go 53.84% <ø> (ø)
app/app.go 87.39% <ø> (-0.07%) ⬇️
app/desmos/cmd/chainlink/create_json.go 54.71% <ø> (ø)
app/encoding.go 100.00% <ø> (ø)
app/wasm_config.go 100.00% <ø> (ø)
x/posts/abci.go 100.00% <ø> (ø)
x/posts/keeper/alias_functions.go 67.51% <ø> (ø)
x/posts/keeper/attachments.go 100.00% <ø> (ø)
x/posts/keeper/external_hooks.go 75.00% <ø> (ø)
x/posts/keeper/genesis.go 94.66% <ø> (ø)
... and 49 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RiccardoM RiccardoM changed the title chore: release v5.0.0 chore!: release v5.0.0 May 3, 2023
@dadamu
Copy link
Contributor

dadamu commented May 4, 2023

The genesis file is using github Lfs, we need to revert this change to fix chain upgrade test:
573ab9b

@dadamu
Copy link
Contributor

dadamu commented May 4, 2023

I notice the "gov" module state of exported genesis file has cosmos SDK 0.47.0 feature, maybe you use the wrong desmos version to export the genesis file.

@RiccardoM RiccardoM removed x/profiles Module that allows to create and manage decentralized social profiles kind/ci Improve the CI/CD x/subspaces Issue on the x/subspaces module x/CLI kind/build Related to the build of the project x/relationships x/fees labels May 4, 2023
@github-actions github-actions bot added kind/build Related to the build of the project kind/ci Improve the CI/CD x/CLI x/fees x/profiles Module that allows to create and manage decentralized social profiles x/relationships x/subspaces Issue on the x/subspaces module labels May 4, 2023
@dadamu
Copy link
Contributor

dadamu commented May 5, 2023

The error happens since setup-localnet is using current desmos version. The generated genesis files inside node0 is desmos-v5.0.0, which is not compatible with v4.8.1 genesis.

I fixed the issue by this commit, please go ahead if you feel it is good enough:
60f7758

In addition, I added the missing storekey ibcfeetypes.StoreKey, icacontrollertypes.StoreKey, icahosttypes.StoreKey to upgrade handler, and also fix params setting issue inside upgrade handler.

@RiccardoM
Copy link
Contributor Author

RiccardoM commented May 5, 2023

@dadamu I should have already taken care of that issue with b5d66c6, which is already on this branch. No need to edit the Makefile when we can simply edit the start.sh script that it's used inside the on-chain upgrade test. Anyway, I don't understand why it's failing on the CI since it's not on my local machine. I'll investigate more now 👍

For the other changes, I'll include them in a future commit.

Update - 05/05/2023 16:00 UTC
Everything seem to be working fine now, until it's time to query the nodes. When I do that, it appears that I cannot connect to the created node from the host machine. I always get the following error:

Connection reset by peer

I honestly don't undestand what has changed to bring this issue up.

Update - 05/05/2023 17:00 UTC
@dadamu I have ported your migration fixes into this branch with 7811569 and e62da8c.

Update - 05/05/2023 19:30 UTC
It appears there are some issue with how the Docker containers are created by Docker compose. I'm temporarely giving up on this as I don't seem to find any way to fix this.

@@ -384,7 +384,7 @@ build-docker-desmosnode:
# Setups 4 folders representing each one the genesis state of a testnet node
setup-localnet: build-linux
if ! [ -f build/node0/desmos/config/genesis.json ]; then $(BUILDDIR)/desmos testnet \
-o ./build --starting-ip-address 192.168.10.2 --keyring-backend=test \
-o ./build --starting-ip-address 192.168.255.2 --keyring-backend=test \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change, as well as other IP-related changes, were made in order to avoid any conflict if developers are connected to a nertwork that uses subnet 192.168.10.0.

@@ -14,7 +14,7 @@ require (
github.com/cosmos/cosmos-proto v1.0.0-beta.2
github.com/cosmos/cosmos-sdk v0.47.2
github.com/cosmos/go-bip39 v1.0.0
github.com/cosmos/gogoproto v1.4.10
github.com/cosmos/gogoproto v1.4.8
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done in order to avoid the following errors when running the desmos query command:

WARNING: proto: file name query.proto does not start with expected testdata/; please make sure your folder structure matches the proto files fully-qualified names
WARNING: proto: file name testdata.proto does not start with expected testdata/; please make sure your folder structure matches the proto files fully-qualified names
WARNING: proto: file name tx.proto does not start with expected testdata/; please make sure your folder structure matches the proto files fully-qualified names
WARNING: proto: file name unknonwnproto.proto does not start with expected testdata/; please make sure your folder structure matches the proto files fully-qualified names

This is caused by how the Protobuf generation is setup inside Cosmos SDK. See here.

@RiccardoM RiccardoM requested review from manu0466 and dadamu May 16, 2023 15:07
@RiccardoM RiccardoM added automerge Automatically merge PR once all prerequisites pass and removed x/profiles Module that allows to create and manage decentralized social profiles x/subspaces Issue on the x/subspaces module x/CLI x/relationships x/fees kind/ci Improve the CI/CD kind/build Related to the build of the project labels May 16, 2023
Co-authored-by: Paul Chen <p22626262@gmail.com>
@github-actions github-actions bot added kind/build Related to the build of the project kind/ci Improve the CI/CD x/CLI x/fees x/profiles Module that allows to create and manage decentralized social profiles x/relationships x/subspaces Issue on the x/subspaces module labels May 16, 2023
@RiccardoM RiccardoM requested a review from dadamu May 16, 2023 16:27
@mergify mergify bot merged commit 0cd5379 into master May 16, 2023
@mergify mergify bot deleted the riccardom/desmos-v5 branch May 16, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass kind/build Related to the build of the project kind/ci Improve the CI/CD requires-upgrade Test the on-chain upgrade for this PR x/CLI x/fees x/profiles Module that allows to create and manage decentralized social profiles x/relationships x/subspaces Issue on the x/subspaces module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants