Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: https://github.com/github/accessibility-audits/issues/7886
Description
This PR refactors the html/css of the disclaimer in the welcome start screen such that it no longer users absolute positioning, but flex grow property to pin it to the bottom. This makes it so when I added overfow-y scrolling that it will scroll with the rest of the content. Also, found that the use of the
zoom
property did not allow scrolling and caused content clipping on most welcome flow screens when using minimum hight so I refactored to use scaling to achieve the same affect of the content taking more space for bigger screens.The above issue only calls out that the "Skip sign in" link is overlapping with other content when minimum screen constraints and 200% zoom. But, after starting working on this I found a few more issues:
CleanShot.2024-05-10.at.09.10.01.mp4
Screenshots
200%
CleanShot.2024-05-10.at.09.16.21.mp4
Scaling:
CleanShot.2024-05-10.at.09.16.21.mp4
Release notes
Notes: [Improved] The welcome start flow content does not overlap or clip when zoomed.