Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip sign in when zoomed #18565

Merged
merged 11 commits into from
May 10, 2024
Merged

Skip sign in when zoomed #18565

merged 11 commits into from
May 10, 2024

Conversation

tidy-dev
Copy link
Contributor

@tidy-dev tidy-dev commented May 7, 2024

xref: https://github.com/github/accessibility-audits/issues/7886

Description

This PR refactors the html/css of the disclaimer in the welcome start screen such that it no longer users absolute positioning, but flex grow property to pin it to the bottom. This makes it so when I added overfow-y scrolling that it will scroll with the rest of the content. Also, found that the use of the zoom property did not allow scrolling and caused content clipping on most welcome flow screens when using minimum hight so I refactored to use scaling to achieve the same affect of the content taking more space for bigger screens.

The above issue only calls out that the "Skip sign in" link is overlapping with other content when minimum screen constraints and 200% zoom. But, after starting working on this I found a few more issues:

  1. Due to using zoom scaling based on app width, if you keep the app at min height and expand horizontally you experience the same clipping.
  2. On most welcome flow screens (not just start), if you 200% some content and controls is clipped off screen made worse by condition number 1.
CleanShot.2024-05-10.at.09.10.01.mp4

Screenshots

200%

CleanShot.2024-05-10.at.09.16.21.mp4

Scaling:

CleanShot.2024-05-10.at.09.16.21.mp4

Release notes

Notes: [Improved] The welcome start flow content does not overlap or clip when zoomed.

@tidy-dev tidy-dev marked this pull request as ready for review May 10, 2024 13:18
Copy link
Member

@sergiou87 sergiou87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the latest changes, it looks and works great!! Nice cleanup 👏 ✨

@tidy-dev tidy-dev merged commit 7b366c1 into development May 10, 2024
7 checks passed
@tidy-dev tidy-dev deleted the skip-sign-in-when-zoomed branch May 10, 2024 15:00
Devon037

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants