Remove remaining <br />
#18444
Merged
Remove remaining <br />
#18444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidy-dev
reviewed
Apr 15, 2024
app/src/ui/diff/index.tsx
Outdated
| @@ -179,9 +179,8 @@ export class Diff extends React.Component<IDiffProps, IDiffState> { | |||
| return ( | |||
| <div className="panel empty large-diff"> | |||
| <img src={NoDiffImage} className="blankslate-image" alt="" /> | |||
| <p>The diff is too large to be displayed by default.</p> | |||
There was a problem hiding this comment.
Should we try to keep it visually as it was before?
Before
After
From accessibility audit documentation, I have branch https://github.com/githuba11y/repo_the_second2/tree/with-github-desktop-readme.md) for reproducing this screen handy.
tidy-dev
reviewed
Apr 15, 2024
Comment on lines
+72
to
+77
| <div className="description"> | ||
| <p>The repository will be removed from GitHub Desktop:</p> | ||
| <p> | ||
| <Ref>{this.props.repository.path}</Ref> | ||
| </p> | ||
| </div> |
tidy-dev
requested changes
Apr 15, 2024
|
Thanks for your feedback! Hopefully all fixed now: 
|
tidy-dev
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a continuation of #18436 , going through every remaining instances of
<br />found in our codebase and replacing them with the appropriate HTML elements.There have been changes in these components:
Only these instances have been left:
<br />elements added to blank lines in diffs, so that copy&pasting those work as expectedScreenshots
Everything should still look the same!
Release notes
Notes: [Fixed] Remove unnecessary br elements and make the app easier to navigate with screen readers