Fix issue with Postgres adapter check when using a subclassed adapter #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any thoughts about this? |
|
Hey @shaer thanks for this. I would like to have a passing test suite before releasing a new version. I'm a little short on bandwidth at the moment; would you be willing to take a look at what's going on with the test suite? |
|
I fixed two issues with travis configuration. (updating ruby version, starting postgresql service), now all the checks have passed. |
|
Perfect, thanks! |
|
Version 3.2.0 released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since
instance_of?only returns true if the object is an instance of that exact class, I changed it tokind_of?to support all subclassed apdabters, for exampleactiverecord-postgis-adapter.