Multiple sequences, first draft with simple test #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Addresses issue derrickreimer#18
samsondav
force-pushed
the
sam/multiple_sequences
branch
from
6664e5f
to
2a75245
Compare
| @@ -11,22 +11,22 @@ | |||
| # | |||
| # It's strongly recommended that you check this file into your version control system. | |||
|
|
|||
| ActiveRecord::Schema.define(version: 20130715002029) do | |||
There was a problem hiding this comment.
This happened because I actually ran the migrations in the dummy app... which probably wasn't necessary.
|
This is looking pretty good @samphilipd! I'll take a closer look shortly, but at first glance it looks to be about ready to ship. |
|
For bookkeeping - addresses #18 |
derrickreimer
added a commit
that referenced
this pull request
Jan 23, 2016
Multiple sequences, first draft with simple test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: OK, I'm reasonably satisfied with this now.
@djreimer thoughts?