[DPMBE-63] 이미지 관련 테스트 코드를 작성한다 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImNM
approved these changes
Jun 12, 2023
Comment on lines
+23
to
+31
|
|
||
| @BeforeEach | ||
| fun setup() { | ||
| val securityContext = SecurityContextHolder.createEmptyContext() | ||
| val authentication = UsernamePasswordAuthenticationToken("1", null, setOf(SimpleGrantedAuthority("ROLE_USER"))) | ||
| securityContext.authentication = authentication | ||
| SecurityContextHolder.setContext(securityContext) | ||
| } | ||
|
|
There was a problem hiding this comment.
SecurityUtils쪽 content가 null이여서 content만들어서 강제로 넣었슴니다! 😁
There was a problem hiding this comment.
이거 AOP 로 테스트 빼다가 저 난감했었는데 이렇게 넣었네요 나중에 제가 @WithMockUser나 커스텀하게 세팅해논거 반영하면 Before 뺄 수도 있을 것 같아요 ( 다른 서비스 다 ContextHolder 필요할 수도 있어서 )
Comment on lines
24
to
28
| // given | ||
| ImageUrlDto( | ||
| url = "https://whatnow.kr/1.jpg", | ||
| key = "1.jpg", | ||
| ) |
Comment on lines
+18
to
+32
| var s3Properties: S3Properties = S3Properties( | ||
| S3Properties.S3Secret( | ||
| accessKey = "accessKey", | ||
| secretKey = "secretKey", | ||
| region = "ap-northeast-2", | ||
| endpoint = "https://kr.object.ncloudstorage.com", | ||
| bucket = "bucket", | ||
| ), | ||
| ) | ||
|
|
||
| var amazonS3: AmazonS3 = | ||
| AmazonS3ClientBuilder.standard() | ||
| .withEndpointConfiguration(AwsClientBuilder.EndpointConfiguration(s3Properties.s3.endpoint, s3Properties.s3.region)) | ||
| .withCredentials(AWSStaticCredentialsProvider(BasicAWSCredentials(s3Properties.s3.accessKey, s3Properties.s3.secretKey))) | ||
| .build() |
There was a problem hiding this comment.
네네 url 생성은 AmazonS3 인터페이스 구현체에서 만들어주네용
실제 key 값들은 Param에 붙는 형태여서 테스트할때는 무방하네욤
BlackBean99
approved these changes
Jun 12, 2023
Comment on lines
+23
to
+31
|
|
||
| @BeforeEach | ||
| fun setup() { | ||
| val securityContext = SecurityContextHolder.createEmptyContext() | ||
| val authentication = UsernamePasswordAuthenticationToken("1", null, setOf(SimpleGrantedAuthority("ROLE_USER"))) | ||
| securityContext.authentication = authentication | ||
| SecurityContextHolder.setContext(securityContext) | ||
| } | ||
|
|
There was a problem hiding this comment.
이거 AOP 로 테스트 빼다가 저 난감했었는데 이렇게 넣었네요 나중에 제가 @WithMockUser나 커스텀하게 세팅해논거 반영하면 Before 뺄 수도 있을 것 같아요 ( 다른 서비스 다 ContextHolder 필요할 수도 있어서 )
Comment on lines
+18
to
+32
| var s3Properties: S3Properties = S3Properties( | ||
| S3Properties.S3Secret( | ||
| accessKey = "accessKey", | ||
| secretKey = "secretKey", | ||
| region = "ap-northeast-2", | ||
| endpoint = "https://kr.object.ncloudstorage.com", | ||
| bucket = "bucket", | ||
| ), | ||
| ) | ||
|
|
||
| var amazonS3: AmazonS3 = | ||
| AmazonS3ClientBuilder.standard() | ||
| .withEndpointConfiguration(AwsClientBuilder.EndpointConfiguration(s3Properties.s3.endpoint, s3Properties.s3.region)) | ||
| .withCredentials(AWSStaticCredentialsProvider(BasicAWSCredentials(s3Properties.s3.accessKey, s3Properties.s3.secretKey))) | ||
| .build() |
|
Controller 테스트만 추가하고 머지하겠습니다 |
|
Kudos, SonarCloud Quality Gate passed! |
kdomo
added a commit
that referenced
this pull request
Jun 16, 2023
* chore: spring security test 의존성 추가 * test: S3Properties Test * test: S3UploadPresignedUrl Service Test * test: GetPresignedUrl UseCase Test * test: Image Controller Test * fix: WAIT, LATE일때 throw 키워드 추가, PictureAdapter로 파일이름 수정 * test: PictureDomain Servicer Test * test: PictureUploadSuccess UseCase Test * test: Picture Adapter Test * style: spotless * test: S3UploadPresignedUrl Service Test resultUrl 수정 * fix: GetPresignedUrl UseCase Test에 ImageUrlDto 필요없는 부분 제거 * test: Picture Controller Test * fix: AutoConfigureMockMvc에 addFilters = false 설정으로 filter 안불러오도록 변경 * style: spotless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
변경로직
참고
AutoConfigureMockMvc 관련
AutoConfigureMockMvc는 mock 테스트 시 필요한 의존성을 불러오는 어노테이션입니다.
하지만 디폴트로 우리가 만든 Security Filter가 아닌 디플트로 지정된 Filter가 불러와집니다.
그렇게 되면서 csrf().disable() 설정을 적용하였지만 디폴트에서는 켜져있기때문에 csrf토큰이 없어서 403 에러가 발생합니다 (POST, DELETE 요청에 한해서)
따라서 Controller Test에서는 Filter를 불러오지 않고 추 후 Security 테스트를 넣기로 결정하였습니당
https://kth990303.tistory.com/408
https://stackoverflow.com/questions/21749781/why-i-received-an-error-403-with-mockmvc-and-junit