[DPMBE-127] 알림 하이라이트를 조회한다 #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlackBean99
approved these changes
Jul 21, 2023
| @@ -27,4 +31,14 @@ class NotificationController( | |||
| ): NotificationResponse { | |||
| return notificationReadUseCase.execute(pageable) | |||
| } | |||
|
|
|||
| @Operation(summary = "하이라이트 조회", description = "약속 ID로 하이라이트를 조회합니다") | |||
| @GetMapping("/highlights/promises/{promiseId}") | |||
There was a problem hiding this comment.
parameter 에서 카멜케이스말고 저는 promise-id 이렇게 작성했었습니다 참고!
| @GetMapping("/highlights/promises/{promiseId}") | ||
| fun getHighlights( | ||
| @PathVariable promiseId: Long, | ||
| @ParameterObject @PageableDefault |
There was a problem hiding this comment.
@PageableDefault(size=10) 이렇게 기본값을 설정해줘도 좋을 것 같아용
There was a problem hiding this comment.
@PageableDefault의 size default가 10으로 알고있는데,
따로 적어줘야하는 이유가 있을지 궁금해요!!
There was a problem hiding this comment.
명시적으로 적어주는게!! 가독성이 좋지 않을까여? 10이 아니더라도 ㅋㅋ
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항