Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPMBE-82] 좌표로 행정동을 조회할 수 있다 #124

Merged
merged 6 commits into from
Jul 1, 2023
Merged

[DPMBE-82] 좌표로 행정동을 조회할 수 있다 #124

merged 6 commits into from
Jul 1, 2023

Conversation

BlackBean99
Copy link
Collaborator

개요

작업사항

  • test 환경에서는 application.yml 에 : 따로 안적어주면 그냥 빈 값 들어가서 에러 터지네요.. 이거때문에 4시간 걸림..ㅠㅜㅠ 멍청이
    database: ${MONGO_DATABASE:reversegeo}이렇게 : Null 이면 안되는 부분들은 적어줘야 하더라구요.

  • 인메모리로 테스트 MongoDB를시도하긴 했는데 잘 안돼서 다음에 flapdoodle 적용시켜서 도입하겠습니다. 이슈 올려둘게요

변경로직

  • MongoDB 는 관련해서 confluence 추가했습니다. 다들 확인!
  • 일반 mongo-start 를 쓰지 않고 reactive 를 사용했습니다. mysql 과 혼용해서 쓰려면 이렇게 선언해줘야 하더라구요. 참고!
@Repository
interface DistrictRepository : ReactiveMongoRepository<District, String>

@BlackBean99 BlackBean99 requested a review from ImNM as a code owner June 30, 2023 16:52
@BlackBean99 BlackBean99 self-assigned this Jun 30, 2023
@BlackBean99 BlackBean99 requested a review from kdomo as a code owner June 30, 2023 16:52
ImNM
ImNM approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@ImNM ImNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아주 나이스~

@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

35.9% 35.9% Coverage
0.0% 0.0% Duplication

kdomo
kdomo approved these changes Jul 1, 2023
View reviewed changes
Copy link
Member

@kdomo kdomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳~!

@BlackBean99 BlackBean99 merged commit 7fcfba7 into develop Jul 1, 2023
3 checks passed
@BlackBean99 BlackBean99 deleted the feature/DPMBE-82 branch July 1, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImNM ImNM ImNM approved these changes

@kdomo kdomo kdomo approved these changes

Assignees

@BlackBean99 BlackBean99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DPMBE-82] 좌표로 행정동을 조회할 수 있다
3 participants
@BlackBean99 @ImNM @kdomo