Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass filename and tree path to detective #111

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AndersDJohnson
Copy link

@AndersDJohnson AndersDJohnson commented Jul 16, 2022

Supports dependents/node-dependency-tree#147.

filename is existing, but treePath will only come with dependents/node-dependency-tree#149.

See example use case in dependents/detective-typescript#48.

@AndersDJohnson AndersDJohnson changed the title feat: pass filename to detective feat: pass filename and tree path to detective Jul 16, 2022
test/index.js Outdated
@@ -231,7 +231,7 @@ describe('node-precinct', () => {
amd: config.amd
});

assert.deepEqual(stub.args[0][1], config.amd);
assert.deepEqual(stub.args[0][1].skipLazyLoaded, config.amd.skipLazyLoaded);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifying these two tests to assert only on the specific property they're setting up, rather than the whole arguments objects, which now include more data irrelevant to this test, including filename.

@XhmikosR
Copy link
Member

@AndersDJohnson please rebase and add a separate test.

@XhmikosR
Copy link
Member

@AndersDJohnson I rebased your branch; now we only need the tests fixed and new ones added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants