Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if the user is the judge or attorney on a case review to determine what actions they see in LegacyTasks #15591
Check if the user is the judge or attorney on a case review to determine what actions they see in LegacyTasks #15591
Changes from 4 commits
4161b23
1ab2768
594915a
c8861a8
a95f849
50828f4
5b1dccb
93766ed
32204ca
2637e23
9ff4ec3
cb937c7
e7df83c
9ed8672
7324458
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: I think this belongs at the sibling level to
when the attorney review process has happened outside of caseflow
, rather than under it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I set up these examples as "when there is an attorney_case_review" and "when there is not an attorney_case_review", but gave them more "real world" descriptions. So I agree that if the attorney has not reviewed the case, the attorney review process hasn't actually happened, inside or outside of caseflow. But thought this grouped a bit nicer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion/Question: aren't these redundant? I don't think we need the shared example here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is indeed! Removing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
juuuust kidding
the first set of tests checks when no attorney case review is present
this test checks when an attorney case review is present but not associated with the user.
Gotta hit all those conditional branches!