AVLJs cannot perform attorney rework tasks

[hschallhorn]

Currently, we determine if a legacy case is "assigned" to someone if the current location of the case is that user, used both when pulling all tasks for a user in queue and all tasks for an appeal in case details. There is no way in vacols to determine if the case is assigned to a judge or an attorney, so we previously assumed based on the users role. With AVLJs however, legacy appeals can be assigned to them as a judge OR as an attorney. To determine if the user should see actions for a judge (ready to be dispatched) or actions for an attorney (decision ready for review), we check to see if a decision document has already been drafted for the case but looking at the document id on the associated DAS record. If there is already a decision drafted, this document id will be non null and we assume this case is with the AVLJ to review (as a judge). If there is no document id, we assume this case is with the AVLJ to draft said document (as an attorney).

caseflow/app/models/queues/legacy_work_queue.rb

Lines 31 to 36 in e51ba91

	# If the user is a judge they are only assigned JudgeLegacyTasks
	# If the user is an acting judge, assume any case that already has a decision doc is assigned to them as a judge
	if user&.vacols_roles&.first&.downcase == "judge" ||
	(user&.acting_judge_in_vacols? && appeal.vacols_case_review.valid_document_id?)
	task_class = JudgeLegacyTask
	end

This was implemented as a quick fix as the deprecation of DAS would solve this issue. One of the many issues with this is that cases cannot be sent back to AVLJs to be reworked as an attorney. As they have already completed a decision, our current logic assumes the case is with them to review the decision they already wrote. This disallows AVLJs from being able to edit dispositions in caseflow

AC

• One of
  • Implement a way to be more explicit about the actions an AVLJ should have when they are assigned a legacy case
  • Write a tech spec

Other fun legacy task things

We determine if a task is a judge assign task or a judge decision review task by checking the DAS record's dereceive, used to indicate that the case has be reassigned beck to the judge.

caseflow/app/models/legacy_tasks/judge_legacy_task.rb

Lines 13 to 22 in 31008c4

	if record.reassigned_to_judge_date.present?
	# If task action is 'assign' that means there was no previous task record yet
	JudgeLegacyDecisionReviewTask.new(
	task.instance_values.merge(
	"previous_task" => LegacyTask.new(assigned_at: record.assigned_to_attorney_date.try(:to_date))
	)
	)
	else
	JudgeLegacyAssignTask.new(task.instance_values)
	end

Open questions

• Can we work with Jed to add something to VACOLS/DAS so that we can easily determine if the case is assigned as a judge or as an attorney?

[hschallhorn]

Timeboxing to a 5 rather than a 3 to give appropriate time to look into implementations before writing a spec