Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Panorama] Fixed typos in context-output paths #36276

Merged
merged 18 commits into from
Sep 30, 2024
Merged

Conversation

michal-dagan
Copy link
Contributor

@michal-dagan michal-dagan commented Sep 12, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Fixed the following:
pan-os-create-service:

The following outputs are missing from yml: Panorama.Services.Description
The following outputs are missing from readme: Panorama.Services.Descritpion

pan-os-custom-block-rule:

The following outputs are missing from readme: Panorama.SecurityRules.ProfileSetting

pan-os-edit-rule:

The following outputs are missing from yml: Panorama.SecurityRules.ProfileSetting

pan-os-get-traffic-logs:

The following outputs are missing from readme: Panorama.TrafficLogs.Logs.BytesReceived, Panorama.TrafficLogs.Logs.BytesSent, Panorama.TrafficLogs.Logs.Bytes

pan-os-list-rules:

The following outputs are missing from yml: Panorama.SecurityRule.SecurityProfile.vulnerability, Panorama.SecurityRule.SecurityProfile.spyware, Panorama.SecurityRule.SecurityProfile.file-blocking, Panorama.SecurityRule.SecurityProfile.data-filtering, Panorama.SecurityRule.SecurityProfile.wildfire-analysis, Panorama.SecurityRule.SecurityProfile.virus, Panorama.SecurityRule.SecurityProfile.url-filtering
The following outputs are missing from readme: Panorama.SecurityRule.SecurityProfile

pan-os-get-security-profiles:

The following outputs are missing from yml: Panorama.Spyware.Rules.Cateogry
The following outputs are missing from readme: Panorama.Spyware.Rules.Category

pan-os-list-virtual-routers:

The following outputs are missing from readme: Panorama.VirtualRouter.ECMP

pan-os-list-tag:

The following outputs are missing from readme: Panorama.Tag.location

pan-os-check-latest-panos-software:

The Following context paths for command pan-os-check-latest-panos-software are found in YML file but are missing         from the README file: Panorama.LatestVersions

pan-os-get-traffic-logs:

The Following context paths for command pan-os-get-traffic-logs are found in YML file but are missing from the     README file: Panorama.TrafficLogs.Logs.Bytes, Panorama.TrafficLogs.Logs.BytesSent,     Panorama.TrafficLogs.Logs.BytesReceived

pan-os-list-redistribution-profiles:

The Following context paths for command pan-os-list-redistribution-profiles are found in YML file but are missing from the README file: Panorama.RedistributionProfile.FilterDestination, Panorama.RedistributionProfile.Action, Panorama.RedistributionProfile.FilterType, Panorama.RedistributionProfile.OSPF, Panorama.RedistributionProfile.Priority, Panorama.RedistributionProfile.FilterInterface, Panorama.RedistributionProfile.BGP, Panorama.RedistributionProfile.Name, Panorama.RedistributionProfile.FilterNextHop

pan-os-get-audit-comment

The Following context paths for command pan-os-get-audit-comment are found in YML file but are missing from the README file: Panorama.AuditComment.rule_name, Panorama.AuditComment.comment, Panorama.AuditComment.rule_type

Must have

  • Tests
  • Documentation

@michal-dagan michal-dagan changed the title update [Panorama] pan-os-create-service - fixed typo in the context output Sep 12, 2024
Copy link

github-actions bot commented Sep 12, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/PAN-OS/Integrations/Panorama
   Panorama.py6091222963%34, 341, 348, 371, 378, 380, 408, 413, 415, 430, 436, 439, 447, 451–452, 456, 458, 461–462, 464, 468–469, 476, 484, 490, 493–494, 498, 549–551, 570, 605, 620, 667, 673, 691, 696, 724–725, 733–734, 791–792, 795, 823–824, 859, 869, 875, 881–882, 884–886, 888, 890–891, 894–895, 897–900, 902, 928–929, 952, 957, 962, 969, 976, 981, 988, 995, 1001, 1014–1015, 1019, 1024–1025, 1027–1028, 1030, 1048–1050, 1058, 1065, 1071–1073, 1075, 1077–1078, 1080, 1087–1089, 1098, 1100–1101, 1103–1104, 1106, 1113, 1220–1221, 1249, 1264, 1266–1267, 1269–1272, 1275–1276, 1278–1280, 1283–1285, 1287–1288, 1290, 1313, 1349, 1382, 1410, 1452, 1455, 1481, 1504, 1533, 1544, 1562, 1571, 1578, 1585–1586, 1589, 1601, 1614–1616, 1618, 1620, 1636, 1642, 1644, 1648, 1650, 1656, 1665, 1672–1673, 1675, 1681, 1688–1689, 1691, 1708, 1716, 1719, 1724, 1747, 1749, 1761, 1763, 1780, 1792, 1839, 1841–1853, 1855, 1904, 1911, 1917, 1924, 1926–1929, 1931, 1947–1951, 1955–1959, 1962, 1964, 1966–1967, 1969, 1971, 1973, 1978, 1985–1986, 1988, 1994, 2001–2002, 2004, 2024, 2026, 2030, 2061, 2063, 2065, 2082, 2092, 2098, 2103, 2113, 2119, 2126–2139, 2141–2142, 2144, 2146, 2150–2159, 2161, 2175, 2183, 2189, 2197–2200, 2202, 2226–2229, 2233, 2241, 2249–2250, 2269–2271, 2276, 2279–2281, 2286, 2301–2305, 2310, 2328–2329, 2331–2339, 2341–2346, 2348–2349, 2351–2354, 2356, 2358, 2363, 2370–2371, 2373, 2379, 2386–2387, 2389, 2408, 2412, 2418–2419, 2421, 2427, 2434, 2440, 2446, 2454–2455, 2457, 2474, 2487, 2493, 2500–2505, 2507, 2509, 2514–2521, 2523, 2537, 2544, 2550, 2558–2561, 2563, 2579–2580, 2582–2584, 2588–2590, 2593, 2595, 2597, 2602, 2609–2610, 2612, 2618, 2625–2626, 2628, 2647, 2651, 2658, 2664, 2670, 2678–2679, 2681, 2695, 2704, 2710, 2717–2719, 2721, 2723, 2727–2730, 2732, 2746, 2753, 2759, 2767–2770, 2772, 2795–2799, 2830, 2833, 2837–2840, 2842, 2844–2845, 2853, 2877, 2880, 2884–2886, 2888, 2897, 2903, 2909, 2917–2918, 2920, 2943, 2952–2953, 2955–2956, 2958, 2965, 2971–2979, 2981–2982, 2989–2993, 2995, 2998, 3013, 3020, 3026, 3034–3037, 3039, 3059–3061, 3099–3100, 3134–3135, 3143, 3188, 3197, 3208–3209, 3211–3213, 3215, 3237, 3239, 3241, 3270–3271, 3343, 3345, 3362–3366, 3368–3373, 3375–3384, 3386–3388, 3392–3394, 3398–3400, 3404–3406, 3410–3412, 3417–3420, 3422–3423, 3428, 3434, 3440, 3448, 3450, 3452, 3497, 3500, 3505, 3512–3517, 3519, 3522–3527, 3531–3536, 3538, 3566, 3574–3575, 3598–3601, 3603–3605, 3607–3610, 3614–3616, 3618–3620, 3622–3625, 3656, 3664, 3670, 3678, 3680–3682, 3684, 3779, 3815–3816, 3831–3833, 3835, 3837, 3839, 3843–3845, 3847–3849, 3851, 3853, 3866, 3892–3896, 3898, 3911–3912, 3918–3920, 3922, 3924–3928, 3939–3959, 3961–3965, 3967, 3977–3978, 3980, 3986–3989, 3991–3995, 3997, 4022–4023, 4029–4030, 4038, 4041–4045, 4054, 4056, 4066, 4139–4141, 4152, 4156, 4166, 4182, 4186–4187, 4189, 4191, 4227, 4232–4234, 4236, 4238, 4240, 4246, 4260–4270, 4272–4276, 4278, 4283–4290, 4292–4294, 4297–4299, 4302–4303, 4305–4307, 4310–4312, 4315–4316, 4318–4319, 4322–4323, 4325–4326, 4329–4330, 4332, 4360, 4362, 4366, 4368, 4370, 4375, 4438, 4442, 4451, 4453, 4455, 4459, 4464–4465, 4467, 4469, 4471, 4473–4474, 4478, 4490, 4494–4495, 4510, 4543, 4547–4548, 4550–4551, 4553, 4557, 4568, 4570, 4574, 4628, 4632, 4690, 4704, 4710, 4716, 4723–4724, 4726, 4743, 4750, 4753, 4759, 4766–4771, 4773, 4775, 4782–4787, 4789, 4805–4806, 4817–4819, 4822–4824, 4833–4837, 4866, 4874, 4880, 4887–4890, 4892, 4905, 4910–4912, 4915–4916, 4919, 4921–4924, 4926, 4932, 4939–4940, 4942–4945, 4947, 4949, 4966, 5014, 5037–5039, 5041, 5047–5048, 5050, 5056, 5063–5064, 5066, 5068, 5082–5085, 5087, 5089, 5095–5096, 5098, 5104, 5111–5115, 5117, 5119, 5122, 5124–5125, 5127, 5129, 5134, 5148–5150, 5152, 5158–5159, 5161, 5167, 5174–5178, 5180, 5182, 5200–5202, 5204–5206, 5225, 5231–5232, 5234–5239, 5245, 5252–5260, 5262–5263, 5266, 5269–5272, 5274, 5276–5278, 5283, 5312, 5314–5317, 5319, 5321, 5326, 5328–5330, 5332, 5350, 5352, 5354, 5356, 5358, 5362, 5364, 5366, 5368, 5370, 5374, 5376, 5378, 5380, 5382, 5384, 5391, 5393–5396, 5398, 5400, 5405, 5407, 5409–5410, 5420–5421, 5423, 5425–5427, 5429–5431, 5470, 5472–5474, 5476–5480, 5482–5484, 5486–5488, 5490–5492, 5494–5497, 5499–5502, 5504–5506, 5508–5510, 5513, 5516–5518, 5534, 5536, 5539, 5542, 5595, 5607–5608, 5610, 5612, 5653–5654, 5658, 5663, 5703–5705, 5707–5710, 5712, 5714, 5719, 5721–5723, 5725, 5756, 5762, 5764, 5766, 5770, 5780, 5784, 5792, 5798, 5802, 5804, 5808, 5810, 5812, 5818, 5836–5842, 5844, 5846–5849, 5851, 5853, 5858, 5860, 5862–5863, 5873–5874, 5877, 5879–5881, 5883–5885, 5888, 5910, 5912, 5918, 5922, 5926, 5938, 5942, 5948, 5957, 5961, 5965, 5970, 5976–5977, 5979–5982, 5984, 5991–6004, 6040, 6046, 6050, 6054–6061, 6063, 6065, 6069, 6073–6081, 6083–6086, 6088, 6090–6091, 6098–6103, 6105, 6107, 6121, 6124, 6131, 6135, 6137, 6140–6141, 6143–6149, 6151, 6154, 6160–6161, 6163–6166, 6168, 6173–6174, 6180–6181, 6188–6192, 6194–6196, 6198–6201, 6203, 6215, 6222–6223, 6230–6238, 6240, 6256, 6265–6268, 6270–6271, 6278–6286, 6288, 6290, 6292–6294, 6296–6297, 6303–6308, 6310, 6343, 6349, 6354, 6358–6359, 6366–6368, 6370–6371, 6373, 6387, 6394–6395, 6402–6407, 6411, 6442, 6444, 6450–6452, 6454, 6466, 6471–6472, 6474, 6480, 6487–6489, 6491, 6493, 6495, 6499–6500, 6503, 6513, 6518, 6523–6524, 6526, 6532, 6539–6543, 6545, 6548–6556, 6558–6559, 6561–6562, 6565, 6577, 6582–6584, 6590, 6597, 6599, 6601, 6605–6606, 6608, 6618, 6623, 6628–6630, 6635, 6642–6644, 6646, 6650–6658, 6660–6661, 6663–6664, 6666, 6704, 6710–6712, 6717, 6724–6726, 6728, 6730, 6733–6734, 6736, 6746, 6751, 6756–6758, 6763, 6770–6773, 6776–6784, 6786–6787, 6789, 6791, 6793, 6805, 6811–6812, 6814, 6819, 6826–6830, 6832, 6834, 6837–6838, 6840, 6850, 6855, 6860–6862, 6867, 6874–6876, 6878, 6881–6883, 6886–6887, 6889–6890, 6892–6893, 6895, 6906, 6911–6913, 6918, 6923, 6928, 6934, 6941, 6943–6944, 6946–6948, 6955, 6960, 6973, 6978, 6980, 6987–6991, 6993–6995, 7006–7007, 7026, 7029–7044, 7046, 7058–7060, 7082, 7088, 7093–7094, 7110–7112, 7121–7127, 7132–7134, 7139, 7141, 7144–7150, 7155–7157, 7162–7163, 7166–7172, 7177–7179, 7184–7185, 7188–7194, 7199–7201, 7206–7207, 7210–7215, 7220–7221, 7226–7227, 7230–7236, 7241–7243, 7248–7249, 7316, 7321, 7332, 7338, 7340, 7344–7347, 7349, 7351–7359, 7375, 7391, 7394, 7412, 7416–7450, 7462, 7465–7466, 7473, 7480, 7482, 7486–7488, 7490–7491, 7493–7496, 7500, 7502, 7506–7508, 7511, 7556, 7566–7567, 7577, 7584, 7586, 7590–7591, 7593–7594, 7596–7597, 7600, 7614, 7621, 7623, 7627–7630, 7632–7633, 7636, 7650, 7657, 7659, 7663–7668, 7672, 7686, 7693, 7695, 7706, 7709–7714, 7716, 7727–7732, 7734, 7738–7740, 7742–7743, 7747–7748, 7761, 7763–7765, 7768, 7787–7788, 7792–7793, 7798, 7804, 7806, 7811, 7818, 7820, 7824–7826, 7828–7830, 7835–7836, 7839, 7841–7844, 7846, 7848, 7863, 7878, 7880, 7885, 7894, 7896, 7900–7901, 7903, 7910, 7920, 7922, 7926–7927, 7931, 7971, 7977–7980, 7995, 8010, 8012, 8016–8017, 8022, 8039, 8041, 8045–8046, 8051, 8092, 8094, 8098–8099, 8104, 8165, 8167, 8171–8172, 8177, 8194, 8196, 8200–8201, 8206, 8214, 8216, 8220–8221, 8225–8227, 8235–8236, 8244, 8262, 8264, 8270, 8272–8273, 8284, 8302, 8310–8314, 8317, 8321, 8327, 8333, 8339–8341, 8354, 8358, 8360–8362, 8376, 8385, 8393–8395, 8397, 8400–8402, 8406, 8410–8412, 8415, 8419, 8425, 8431–8432, 8435, 8476–8478, 8481, 8492, 8499, 8504, 8522, 8525, 8531–8532, 8542–8543, 8553–8554, 8563–8572, 8576, 8582–8583, 8592–8593, 8601, 8607, 8612, 8616–8619, 8621, 8623, 8627–8628, 8630, 8640, 8674–8675, 8677–8678, 8681, 8683–8688, 8690, 8699–8700, 8713–8714, 8829, 8851, 8868, 8932, 8955–8956, 8964–8965, 8990, 9002, 9016–9018, 9033, 9038–9040, 9069, 9080–9081, 9085, 9099–9100, 9106, 9146–9150, 9156, 9163–9166, 9169–9171, 9173, 9183, 9189–9191, 9193–9194, 9196, 9204, 9206, 9208, 9210, 9248, 9259–9260, 9391, 9720, 9967, 10149, 10277, 10287, 10332, 10430, 10437–10439, 10443, 10450–10452, 10473, 10480–10482, 10518, 10521–10522, 10624, 10631–10633, 10663–10665, 10667, 10670–10671, 10678, 10695–10698, 10704–10705, 10712, 10730–10733, 10739–10740, 10747, 10958–10960, 10962–10965, 10967, 10969–10970, 10972–10973, 10977–10978, 10988, 11079–11082, 11087, 11127, 11287, 11289–11291, 11310, 11325–11327, 11333, 11414–11415, 11417, 11429, 11441, 11453, 11467, 11479, 11491, 11505, 11519, 11533, 11548, 11570, 11572, 11597, 11617, 11628, 11638, 11649, 11666, 11684, 11706, 11724, 11740, 11760, 11782, 11797, 11807, 11843, 11857, 11876, 11895, 11931, 11951–11952, 11954, 11956, 11967–11972, 11974, 11998, 12010–12011, 12013–12014, 12021–12023, 12027–12028, 12030–12031, 12035, 12068, 12097, 12165, 12194, 12207, 12227–12230, 12234, 12242–12247, 12253–12258, 12293, 12303, 12306, 12340–12347, 12350, 12352–12354, 12375, 12380–12383, 12393, 12397, 12401, 12428, 12439, 12474, 12527, 12690–12693, 12771, 12810, 12914, 12974, 12985, 13079, 13081, 13103–13106, 13110, 13160, 13232, 13256, 13292, 13338, 13708, 13735–13736, 13778, 13847, 13859, 13956–13959, 13961, 13991, 13993–13995, 13997–13998, 14052–14053, 14055–14057, 14064–14066, 14072, 14097–14099, 14101, 14107–14108, 14110–14111, 14113–14114, 14116, 14118, 14164, 14186–14188, 14190, 14211, 14241, 14256, 14260, 14322, 14327, 14362–14364, 14368, 14450, 14464, 14466, 14529, 14531–14533, 14579–14580, 14583–14584, 14586–14590, 14592, 14594–14597, 14877, 14937, 14939–14941, 14943–14948, 14950–14951, 14955
TOTAL6091222963% 

Tests Skipped Failures Errors Time
1276 0 💤 0 ❌ 0 🔥 28.624s ⏱️

@michal-dagan michal-dagan changed the title [Panorama] pan-os-create-service - fixed typo in the context output [Panorama] Fixed typos in context-output paths Sep 12, 2024
Copy link
Contributor

@shmuel44 shmuel44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve from my side. (As a reporter of the ticket)

@ShirleyDenkberg
Copy link
Contributor

@shmuel44 @jlevypaloalto @bziser Doc review completed.

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@michal-dagan michal-dagan added the ForceMerge Forcing the merge of the PR despite the build status label Sep 30, 2024
@michal-dagan
Copy link
Contributor Author

@DeanArbel - Force Merge -
run-validations-new-validate-flow, pre-commit failed on
[BC102] - Changing output context paths is not allowed. Restore the following outputs: In the pan-os-create-service command, the following outputs are missing for backward-compatability: Panorama.Services.Descritpion

@DeanArbel DeanArbel merged commit 8bf6a12 into master Sep 30, 2024
18 of 20 checks passed
@DeanArbel DeanArbel deleted the fix-panorama-context branch September 30, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants