improvement: scroll selected account into view #4137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
added a commit
that referenced
this pull request
Sep 16, 2024
...on initial render, and if needed when changing selection. Partially addresses #4137
WofWca
force-pushed
the
wofwca/scroll-account-into-view
branch
from
e5416c8
to
b67fffe
Compare
Simon-Laux
reviewed
Sep 16, 2024
| // based on that, and whether it is displayed or not determines the | ||
| // scrollHeight of the accounts list, so we want to make sure | ||
| // to scroll after it gets displayed. | ||
| // TODO refactor: maybe just use `ResizeObserver`, |
There was a problem hiding this comment.
also sounds good because users may change the height of the window and thus scroll the selected account out of view.
...on initial render, and if needed when changing selection. Partially addresses #4137
WofWca
force-pushed
the
wofwca/scroll-account-into-view
branch
from
b67fffe
to
7d92739
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...on initial render, and if needed when changing selection.