cleanup account switcher #3310
Open
cleanup account switcher #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not show 'Add Profile' in bold. this looks less cluttered and makes the "bold" of the selected account more outstanding: before, there were two types of "boldness", the add profile button (using bold only) and the selected profile (using bold and a background), this results in a bit cluttered, unsteady look, esp. when there are few accounts and more bold than normal is shown. also, this makes "bold" more outstanding, as this attribute is given to one line only. there is no need for the "add profile" to be that outstanding (in contrast to eg. the "add chat" dialog) it is a minor, sure :)
|
To test the changes in this pull request, install this apk: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not show 'Add Profile' in bold.
this looks less cluttered
and makes the "bold" of the selected account more outstanding:
before, there were two types of "boldness",
the add profile button (using bold only)
and the selected profile (using bold and a background), this results in a bit cluttered, unsteady look,
esp. when there are few accounts and more bold than normal is shown.
also, this makes "bold" more outstanding,
as this attribute is given to one line only.
there is no need for the "add profile" to be that outstanding (in contrast to eg. the "add chat" dialog)
the "Add Profile" button with its "+" is still recognisable enough and is not really mixed with an existing profile. otherwise, we could add some more whitespace between the accounts and "add profile". btw: wondering if "Add Profile" shouln't be the last item
it is a minor, sure :)
before - a bit noisy abd kooking as if twi things are selected:
after - less agitated: