New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing govet errors #320

Draft

MaksimDell wants to merge 4 commits into main from improvement/fix-linting

Contributor

MaksimDell commented Aug 16, 2024 •

edited

Loading

Description

In this PR I want to fix all linting issues

Checklist:

Have you run format,vet & lint checks against your submission?
Have you made sure that the code compiles?
Did you run the unit & integration tests successfully?
Have you maintained at least 90% code coverage?
Have you commented your code, particularly in hard-to-understand areas
Have you done corresponding changes to the documentation
Did you run tests in a real Kubernetes cluster?
Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

MaksimDell added 4 commits

August 16, 2024 12:58


          fixing govet errors

85318ca


          fix go vet errors

3a1347a


          fix go vet errors

07828a0


          fix gofumpt

2aaf44e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

abhi16394 Awaiting requested review from abhi16394 abhi16394 will be requested when the pull request is marked ready for review abhi16394 is a code owner

adarsh-dell Awaiting requested review from adarsh-dell adarsh-dell will be requested when the pull request is marked ready for review adarsh-dell is a code owner

AkshaySainiDell Awaiting requested review from AkshaySainiDell AkshaySainiDell will be requested when the pull request is marked ready for review AkshaySainiDell is a code owner

bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 will be requested when the pull request is marked ready for review bpjain2004 is a code owner

donatwork Awaiting requested review from donatwork donatwork will be requested when the pull request is marked ready for review donatwork is a code owner

tdawe Awaiting requested review from tdawe tdawe will be requested when the pull request is marked ready for review tdawe is a code owner

At least 2 approving reviews are required to merge this pull request.

Labels

None yet