Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve the order of decorators by declaration #1200

Merged
merged 1 commit into from
May 25, 2023
Merged

Preserve the order of decorators by declaration #1200

merged 1 commit into from
May 25, 2023

Conversation

Sgitario
Copy link
Collaborator

No description provided.

@Sgitario Sgitario requested a review from iocanel May 24, 2023 08:37
iocanel
iocanel approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarcloud
Copy link

sonarcloud bot commented May 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Sgitario
Copy link
Collaborator Author

PR rebased to run the downstream job with these changes.

@Sgitario
Copy link
Collaborator Author

The failures on the snowdrop examples are expected until we can upgrade Dekorate to the latest version. Merging.

@Sgitario Sgitario merged commit 21344d1 into dekorateio:main May 25, 2023
@Sgitario Sgitario deleted the fix_order_good branch May 25, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iocanel iocanel iocanel approved these changes

Assignees
No one assigned
Labels
downstream-check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sgitario @iocanel