fix: refactor process.exit to exception #698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor process.exit to exception Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
naveensrinivasan
requested review from
jeff-mccoy,
cmwylie19,
btlghrants and
schaeferka
as code owners
cmwylie19
reviewed
Apr 2, 2024
Co-authored-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
|
Hi @naveensrinivasan, Something really funky is going on. There is an startup function that is being invoke when you import I suggest moving validateHash to helpers like in #707 and changing the package.json back. You can use that PR (#707) as your reference and we can close it afterwards. |
|
addressed in #707 I wanted to test something and did not want to pollute your PR. It was passing locally but not in CI. Thank you for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Fixes #
Relates to #
Type of change
Checklist before merging