Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: filterNoMatchReason and shouldSkipRequest #1161

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

btlghrants
Copy link
Collaborator

@btlghrants btlghrants commented Sep 20, 2024

Description

src/lib/helpers.ts and src/lib/filter.ts are becoming unwieldy -- this PR is intended to make them simpler to grok / move forward on.

Related Issue

Fixes # #1154

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@btlghrants btlghrants self-assigned this Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.95%. Comparing base (ade478d) to head (7753533).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1161      +/-   ##
==========================================
+ Coverage   85.87%   85.95%   +0.07%     
==========================================
  Files          27       27              
  Lines        1126     1132       +6     
  Branches      231      231              
==========================================
+ Hits          967      973       +6     
  Misses        157      157              
  Partials        2        2              
Files with missing lines Coverage Δ
src/lib/helpers.ts 97.14% <100.00%> (+0.10%) ⬆️

@cmwylie19 cmwylie19 added this to the v0.37.0 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

2 participants