-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new little requested features #875
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9bc0611
add new little requested features
pavanvidem 2795d39
Revert the old 3-column BED input in addition to the new 4-column BED
pavanvidem 0c0fd76
add tests
pavanvidem 118949f
fix linting
pavanvidem 74f990f
update requirements scikit-learn 1.3
pavanvidem ac380c6
also update in setup.py
pavanvidem 55a5dc3
remove print statements
pavanvidem 8fd8066
change requirement in setup.py and comment in BED reading
pavanvidem c416e9a
write a 6-column BED instead of a 4-column one
pavanvidem File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+61 KB
hicexplorer/test/test_data/cHi-C/chicAggregateStatistic/aggregate_target.hdf
Binary file not shown.
8 changes: 0 additions & 8 deletions
8
hicexplorer/test/test_data/cHi-C/chicAggregateStatistic/target_list.bed
This file was deleted.
Oops, something went wrong.
8 changes: 8 additions & 0 deletions
8
hicexplorer/test/test_data/cHi-C/chicAggregateStatistic/target_list_3col.bed
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
chr1 4480000 4549000 | ||
chr1 4555000 4688000 | ||
chr1 14274000 14279000 | ||
chr1 14290000 14439000 | ||
chr1 14444000 14467000 | ||
chr1 14476000 14501000 | ||
chr1 19077000 19118000 | ||
chr1 19120000 19274000 |
3 changes: 3 additions & 0 deletions
3
hicexplorer/test/test_data/cHi-C/chicAggregateStatistic/target_list_4col.bed
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
chr1 4487335 4487535 Sox17 | ||
chr1 14300180 14300380 Eya1 | ||
chr1 19093003 19093203 Tfap2d |
Binary file added
BIN
+175 KB
hicexplorer/test/test_data/cHi-C/chicViewpoint/two_matrices_custom_keys.hdf5
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the variable name
_line
confusing. They are now elements or something like that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be consistent with the remaining project I used
_line
. The same line of code can be found several times.