client/asset/eth: add RPC client #1832

buck54321 · 2022-08-30T22:29:05Z

client/asset/eth:
Adds an RPC client that can maintain one or more websocket (preferred), http, or
ipc connections. Implements ethFetcher as well as bind.ContractBackend. Websocket
connections have a block header feed, so need to make fewer requests. For http
connections, the block header requests are metered to one per 10 seconds.
If no nonces are involved, the provider to use for a request is picked randomly,
but closely grouped requests involving nonces will attempt to use the same provider.

client/asset: Add Repeatable bool field to ConfigOption to allow multiple
inputs.

ui: Work with new repeatable input type.

client/asset/eth/multirpc.go

martonp

Looks really nice, but I was unable to get it to work on simnet. I used the ipc file to add a provider, and at first it says it has connected to a peer, but when I try to make a trade, it fails saying that it has no peers.

Also, there is a UI issue. If I have a native wallet already created, I cannot see the Recieve/Send buttons, and I cannot switch to the rpc wallet. When I have no wallets created, I do not see the option of creating a native wallet.

client/asset/eth/eth.go

martonp · 2022-09-03T06:00:05Z

client/asset/eth/multirpc.go

+	}
+
+	m.receipts.Lock()
+	m.receipts.cache[txHash] = &receiptRecord{


I think we shouldn't cache until the receipt has a certain number of confirmations. If we cache in the first block it is mined, then there is a reorg, it could cause issues.

martonp · 2022-09-03T06:13:02Z

client/asset/eth/multirpc.go

+		lastProvider = p
+		m.log.Tracef("Sending signed tx via %q", p.host)
+		err := p.ec.SendTransaction(ctx, tx)
+		if err != nil && strings.Contains(err.Error(), core.ErrAlreadyKnown.Error()) {


Why not errors.Is instead of the strings.Contains?

Coming through the (rpc.Client).CallContext, we lose the type.

martonp · 2022-09-03T06:16:10Z

client/asset/eth/multirpc.go

+}
+
+func (m *multiRPCClient) syncProgress(ctx context.Context) (prog *ethereum.SyncProgress, err error) {
+	return prog, m.withAny(func(p *provider) error {


What if some providers are synced and some are not? Should we just return 100% synced progress, and in the other methds use the providers that have already finished syncing?

client/asset/eth/multirpc.go

martonp · 2022-09-03T06:45:43Z

client/webserver/site/src/html/forms.tmpl

@@ -21,6 +21,13 @@
      <input type="date" class="form-control select">
    </div>
  </div>
+  <div data-tmpl="repeatableInput" class="w-100">


This should have an option to remove additional rows.

buck54321 · 2022-09-07T03:01:25Z

Looks really nice, but I was unable to get it to work on simnet. I used the ipc file to add a provider, and at first it says it has connected to a peer, but when I try to make a trade, it fails saying that it has no peers.

I think I've resolved some things now @martonp, if you're up for another spin.

Also, there is a UI issue. If I have a native wallet already created, I cannot see the Recieve/Send buttons, and I cannot switch to the rpc wallet. When I have no wallets created, I do not see the option of creating a native wallet.

Oh. Interesting. Cuz I've removed support for native wallets. I'll figure this out.

martonp

All the functionality seems to be working well now, except for the redemption confirmation which works after fixing getTransaction.

martonp · 2022-09-08T10:38:20Z

client/asset/eth/multirpc.go

+			return err
+		}
+		tx = resp.tx
+		if resp.BlockNumber != nil {


This resp.BlockNumber string has a "0x" in the front, causing the hex.DecodeString call to return an error. Also this function should return -1 for the height if the tx has not yet been mined.

JoeGruffins

partial review

JoeGruffins · 2022-09-12T05:54:37Z

client/asset/eth/eth.go

+			providers, err := connectProviders(ctx, endpoints, createWalletParams.Logger, big.NewInt(chainIDs[createWalletParams.Net]))
+			if err != nil {
+				return err
+			}


Feels weird to have to connect in create, but I see it runs some initial checks. Still maybe could be done in the first Connect. We have a ctx arg there and not here intentionally.

JoeGruffins · 2022-09-12T06:27:25Z

client/asset/eth/multirpc.go

+// use the same provider if < nonceProviderStickiness has passed.
+var nonceProviderStickiness = time.Minute
+
+// TODO: Handle rate limiting? From the docs:


Which docs?

JoeGruffins · 2022-09-12T06:33:13Z

client/asset/eth/multirpc.go

+	ws      bool
+	tipCapV atomic.Value // *cachedTipCap
+
+	// tip tracks the best known header as well as any error encount


encount -> encountered

JoeGruffins · 2022-09-12T06:35:33Z

client/asset/eth/multirpc.go

+	stale := time.Second * 10
+	if p.ws {
+		stale = time.Minute * 2
+	}


Why longer for websocket? (is ws websocket)

Oh, because subscription maybe?

Right. We expect them to come through the subscription.

JoeGruffins · 2022-09-12T06:41:38Z

client/asset/eth/multirpc.go

+// failed will be true if setFailed has been called in the last failQuarantine.
+func (p *provider) failed() bool {


Also true if the provider has failed > 100 times.

JoeGruffins · 2022-09-12T08:05:53Z

client/asset/eth/multirpc.go

+		if strings.Contains(errStr, s) {
+			return true
+		}


Probably fine, but if mi is not a string or error s will always be "" and have a true return.

That's true, and I think I'm okay with it. I would understand if anyone was adamant that I do it different though.

JoeGruffins · 2022-09-12T08:08:48Z

client/asset/eth/multirpc.go

+	}
+	if len(readyProviders) == 0 {
+		// Just try them all.
+		m.log.Tracef("all providers in a failed state, so acting like none are")


Maybe this is a warn?

I think this would be somewhat common when using a single provider.

JoeGruffins · 2022-09-12T08:20:27Z

client/asset/eth/multirpc.go

+		if superError == nil {
+			superError = err
+		} else {
+			superError = fmt.Errorf("%v: %w", superError, err)
+		}


Not sure if this maybe returns below before the error log, but could add info about the provider to this error?

It seems like the error is just ignored sometimes. Could always log anyway? Debug log even if it's not really a problem?

JoeGruffins · 2022-09-12T08:36:07Z

client/asset/eth/multirpc.go

+
+	for _, p := range m.providers {
+		if lastProvider != nil && lastProvider.host == p.host {
+			continue // already added it


Is comment correct? Looks like will add later. Or rather add everything else to it.

JoeGruffins · 2022-09-12T08:57:36Z

client/asset/eth/multirpc.go

+		// This block choosing algo is probably too rudimentary. Really need
+		// shnuld traverse parents to a common block and sum up gas (including
+		// uncles?), I think.


shnuld -> should

Why is GasUsed is in the equation?

We don't need to worry about uncles as they will not exist anymore, according to reddit https://www.reddit.com/r/ethstaker/comments/vwdki8/will_ommeruncle_blocks_exist_after_the_merge/

Isn't GasUsed the rough equivalent of work in ethereum? I'm not clear on how that works I guess.

I'm not either. It may be that more gas used has more weight.

I wouldn't guess that gas used has any thing to do with it either. Not saying it doesn't, but are there any references on this?

JoeGruffins · 2022-09-13T04:56:27Z

client/asset/eth/multirpc.go

+				return nil
+			}
+			if propagate {
+				return err


Maybe intended but this eats superError

JoeGruffins · 2022-09-13T05:03:26Z

client/asset/eth/multirpc.go

+			if fail {
+				p.setFailed()
+			}


May be misreading, but if there were two providers and the first one errored and took this fail path while the second one succeeded then method would return the non nil superError although succeeding with the second provider.

I had that messed up. Thanks.

JoeGruffins · 2022-09-13T05:10:37Z

client/asset/eth/multirpc.go

+// depending on what they are. Zero or more acceptabilityFilters can be added
+// to provide extra control.
+//
+//	 discard: If a filter indicates discard = true, the error will be discarded,


nit: extra space in front of discard.

JoeGruffins · 2022-09-13T05:22:35Z

client/asset/eth/multirpc.go

+func (m *multiRPCClient) sendSignedTransaction(ctx context.Context, tx *types.Transaction) error {
+	var lastProvider *provider
+	if err := m.withPreferred(func(p *provider) error {
+		lastProvider = p
+		m.log.Tracef("Sending signed tx via %q", p.host)
+		return p.ec.SendTransaction(ctx, tx)
+	}, func(err error) (discard, propagate, fail bool) {
+		return errorFilter(err, core.ErrAlreadyKnown, "known transaction"), false, false
+	}); err != nil {
+		return err
+	}
+	m.lastProvider.Lock()
+	m.lastProvider.provider = lastProvider
+	m.lastProvider.stamp = time.Now()
+	m.lastProvider.Unlock()
+	return nil
+}


It looks like two of these running in parallel could have different providers set in close proximity, possible defeating the purpose of keeping the nonce in order.

JoeGruffins · 2022-09-13T05:30:31Z

client/asset/eth/multirpc.go

+// syncProgress: We're going to lie and just always say we're synced if we
+// can get a header.


Could make an exception for IPC?

JoeGruffins · 2022-09-13T05:37:45Z

client/asset/eth/multirpc.go

+			if strings.Contains(err.Error(), "not found") {
+				notFound = true
+			}


Could use the errorFilter you made.

Can't use it here, because a subsequent provider might find it.

JoeGruffins · 2022-09-13T05:46:33Z

client/asset/eth/multirpc.go

+type rpcTest struct {
+	name string
+	f    func(*provider) error
+}


Testing things could be in a test file?

JoeGruffins · 2022-09-13T07:00:31Z

Maybe unrelated, but seeing for the first time on loadbot:

2022-09-13 15:54:52.160 [INF] MANTLE:CMPD:STACKER:1: created wallet dcr:iJt1 on node alpha
2022-09-13 15:54:52.189 [ERR] LOADBOT: exec error (dcr) "./alpha": exit status 1: -4: wallet.SendOutputs: double spend:: wallet.processTransactionRecord: 2f3cce875cae0b95a5d9b4deb30fc578f64ca2d4183eea84b0b8271f3dc66572 conflicts with 8fe8d127a39ecccf0d902fb4cabfbb32b8913948f801aacf64e71d4a9c1ba179 by double spending 6d58f2b8f0fb8412a4405dd9a99938733cec08256593c9992ca9d1199a1a54c6:2

2022-09-13 15:54:52.189 [CRT] MANTLE:CMPD:SNIPER:0: exit status 1
2022-09-13 15:54:52.189 [ERR] LOADBOT: exec error (dcr) "./alpha": exit status 1: -4: wallet.SendOutputs: double spend:: wallet.processTransactionRecord: 2dd5e335aac0763164798611d737e2bfdcd6bbc23b614b368306e7d1cd1c305d conflicts with 8fe8d127a39ecccf0d902fb4cabfbb32b8913948f801aacf64e71d4a9c1ba179 by double spending ecbe09281f2ae1d0f1144c07c518b156941cc6e437b5badadbfae9b6788840fa:0

2022-09-13 15:54:52.189 [CRT] MANTLE:CMPD:PINGPONG:0: exit status 1

Seems to have been random as has not happened again.

JoeGruffins · 2022-09-13T07:35:57Z

Trying to set up with the alpha rpc, I guess home symbol is not expanded here and I get the error 2022-09-13 16:23:48.491 [ERR] CORE[CREATE]: error creating http client for "~/dextest/eth/alpha/node/geth.ipc": dial unix ~/dextest/eth/alpha/node/geth.ipc: connect: no such file or directory which is fine but it won't let me try again until I restart the app or wait for a panic that seems to come:

I can make infinite providers but cannot remove the boxes. Doesn't need to be fixed now I guess:

Working well using the simnet harness alpha node! My testnet has almost synced... probably. Will try to set up for testing there.

JoeGruffins · 2022-09-16T08:53:49Z

Loading up testnet, I am unable to change my wallet settings for eth, there are no options:

buck54321 · 2022-09-20T11:56:26Z

client/core/core.go

 	if err != nil {
+		if errors.Is(err, asset.ErrWalletTypeDisabled) {
+			subject, details := c.formatDetails(TopicWalletTypeDeprecated, unbip(assetID))
+			c.notify(newWalletConfigNote(TopicWalletTypeDeprecated, subject, details, db.WarningLevel, nil))
+		}
 		return nil, fmt.Errorf("error opening wallet: %w", err)
 	}


I started into a scheme where we just disable the wallet, but it was a can of worms. Instead, we're refusing to open a deprecated wallet in e.g. eth.NewWallet and issuing a warning. This is no problem for us right now, because the only other option for Ethereum is also a seeded wallet and will derive the same key. But if there was a need to export a seed from a deprecated wallet, we would need to get more sophisticated here.

JoeGruffins · 2022-09-21T05:18:52Z

panic while testing on testnet using infura:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0xbd4e81]

goroutine 5948022 [running]:
decred.org/dcrdex/client/asset/eth.(*multiRPCClient).transactionReceipt(0xc0002462c0, {0x1f0c358, 0xc001212200}, {0xe0, 0x40, 0x25, 0xcc, 0xc7, 0xe5, 0xc7, ...})
        /home/joe/git/dcrdex/client/asset/eth/multirpc.go:536 +0x1c1
decred.org/dcrdex/client/asset/eth.(*assetWallet).confirmRedemption(0xc000246210, {0xc01124eae0?, 0x4110c7?, 0x20?}, 0xc011c40300, 0xc000dfe501?)
        /home/joe/git/dcrdex/client/asset/eth/eth.go:3237 +0xd8a
decred.org/dcrdex/client/asset/eth.(*ETHWallet).ConfirmRedemption(0x1f03d40?, {0xc01124eae0?, 0xc000dfe570?, 0x1?}, 0xc004954c90?)
        /home/joe/git/dcrdex/client/asset/eth/eth.go:3003 +0x25
decred.org/dcrdex/client/core.(*trackedTrade).confirmRedemption(0xc0006b6300, 0xc001031a00)
        /home/joe/git/dcrdex/client/core/trade.go:2538 +0x165
decred.org/dcrdex/client/core.(*Core).tick(0xc00016d680, 0xc0006b6300)
        /home/joe/git/dcrdex/client/core/trade.go:1777 +0x1c7d
decred.org/dcrdex/client/core.(*Core).tickAsset.func1()
        /home/joe/git/dcrdex/client/core/core.go:963 +0x45
created by decred.org/dcrdex/client/core.(*Core).tickAsset
        /home/joe/git/dcrdex/client/core/core.go:962 +0x277

Unable to recover, keeps panicking when I start up.

Other than that working well!

JoeGruffins · 2022-09-21T05:25:03Z

Also, weird critical error for the server randomly @chappjc:

2022-09-21 14:22:56.000 [CRT] MKT: Archivist failing. Last unexpected error: pq: column "preimage" is of type bytea but expression is of type integer
2022-09-21 14:22:56.000 [CRT] MKT: aborting epoch processing on account of failing DB: pq: column "preimage" is of type bytea but expression is of type integer
2022-09-21 14:22:56.000 [DBG] MKT: epoch pump drained for market eth_dcr
2022-09-21 14:22:56.000 [INF] MKT: Market "eth_dcr" stopped.
2022-09-21 14:22:56.000 [INF] MKT: Market "eth_dcr" suspended after epoch 103983611, persist book = true.

full logs:
dcrdextestnet.txt

buck54321 · 2022-09-21T06:25:10Z

panic while testing on testnet using infura:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0xbd4e81]

goroutine 5948022 [running]:
decred.org/dcrdex/client/asset/eth.(*multiRPCClient).transactionReceipt(0xc0002462c0, {0x1f0c358, 0xc001212200}, {0xe0, 0x40, 0x25, 0xcc, 0xc7, 0xe5, 0xc7, ...})
        /home/joe/git/dcrdex/client/asset/eth/multirpc.go:536 +0x1c1
decred.org/dcrdex/client/asset/eth.(*assetWallet).confirmRedemption(0xc000246210, {0xc01124eae0?, 0x4110c7?, 0x20?}, 0xc011c40300, 0xc000dfe501?)
        /home/joe/git/dcrdex/client/asset/eth/eth.go:3237 +0xd8a
decred.org/dcrdex/client/asset/eth.(*ETHWallet).ConfirmRedemption(0x1f03d40?, {0xc01124eae0?, 0xc000dfe570?, 0x1?}, 0xc004954c90?)
        /home/joe/git/dcrdex/client/asset/eth/eth.go:3003 +0x25
decred.org/dcrdex/client/core.(*trackedTrade).confirmRedemption(0xc0006b6300, 0xc001031a00)
        /home/joe/git/dcrdex/client/core/trade.go:2538 +0x165
decred.org/dcrdex/client/core.(*Core).tick(0xc00016d680, 0xc0006b6300)
        /home/joe/git/dcrdex/client/core/trade.go:1777 +0x1c7d
decred.org/dcrdex/client/core.(*Core).tickAsset.func1()
        /home/joe/git/dcrdex/client/core/core.go:963 +0x45
created by decred.org/dcrdex/client/core.(*Core).tickAsset
        /home/joe/git/dcrdex/client/core/core.go:962 +0x277

Unable to recover, keeps panicking when I start up.

Other than that working well!

My bad. Fixed, and I've actually tested it on testnet this time. I've got some orders up on testnet dcr-eth tonight if you get back around to testing.

buck54321 · 2022-09-21T06:26:54Z

Also, weird critical error for the server randomly @chappjc:

2022-09-21 14:22:56.000 [CRT] MKT: Archivist failing. Last unexpected error: pq: column "preimage" is of type bytea but expression is of type integer
2022-09-21 14:22:56.000 [CRT] MKT: aborting epoch processing on account of failing DB: pq: column "preimage" is of type bytea but expression is of type integer
2022-09-21 14:22:56.000 [DBG] MKT: epoch pump drained for market eth_dcr
2022-09-21 14:22:56.000 [INF] MKT: Market "eth_dcr" stopped.
2022-09-21 14:22:56.000 [INF] MKT: Market "eth_dcr" suspended after epoch 103983611, persist book = true.

full logs: dcrdextestnet.txt

Uh. This is kinda nuts.

JoeGruffins · 2022-09-21T11:40:17Z

Trades worked!
Unrelated to this pr, but is this right? I try to market buy with 2 eth but that becomes .2 eth:

JoeGruffins · 2022-09-23T07:42:14Z

client/asset/eth/multirpc.go

+		case err, ok := <-sub.Err():
+			if !ok {
+				// Subscription cancelled
+				return
+			}
+			log.Errorf("%q header subscription error: %v", p.host, err)
+			log.Info("Attempting to resubscribe to %q block headers", p.host)
+			sub, err = newSub()
+			if err != nil { // context cancelled
+				return
+			}


Trying the nodeclient tests on testnet I will see:

2022-09-23 15:11:34.532 [ERR] ETHTEST: "goerli.infura.io" header subscription error: <nil> 2022-09-23 15:11:34.532 [WRN] ETHTEST: can't resubscribe to "goerli.infura.io" headers: client is closed 2022-09-23 15:11:36.135 [ERR] ETHTEST: "goerli.infura.io" header subscription error: <nil> 2022-09-23 15:11:36.135 [WRN] ETHTEST: can't resubscribe to "goerli.infura.io" headers: client is closed

Expected?

client/asset/eth/nodeclient_harness_test.go

chappjc

Initial comments. More today.

client/asset/eth/multirpc.go

chappjc · 2022-09-28T16:30:04Z

client/asset/eth/multirpc.go

+			ec.Close()
+			log.Errorf("Failed to get header from %q: %v", endpoint, err)
+			continue
+		}


Maybe a ec.HeaderByHash(ctx, hdr.Hash()) check as well now that it's needed?

JoeGruffins · 2022-09-30T07:52:12Z

client/asset/eth/multirpc.go

+	// TODO
+	// TODO: Plug into the monitoredTx system from #1638.
+	// TODO
+	if tx, _, err = m.getTransaction(ctx, txHash); err != nil {
+		return nil, nil, err
+	}


Was this addition intentional? We already have the tx.

client/asset/eth/multirpc.go

chappjc · 2022-10-17T15:59:03Z

If everybody could circle back on their reviews and resolve or bump suggestions, we're nearly ready to get this in.
@martonp @JoeGruffins

client/asset/eth/eth_test.go

client/asset/eth/eth.go

client/asset/eth/multirpc.go

martonp · 2022-10-17T21:22:47Z

https://github.com/decred/dcrdex/pull/1832/files#r965796162

@buck54321 You fixed this in 325a552 but somehow it is back now.

client/asset/eth: Adds an RPC client that can maintain one or more websocket (preferred), http, or ipc connections. Implements ethFetcher as well as bind.ContractBackend. Websocket connections have a block header feed, so need to make fewer requests. For http connections, the block header requests are metered to one per 10 seconds. If no nonces are involved, the provider to use for a request is picked randomly, but closely grouped requests involving nonces will attempt to use the same provider. client/asset: Add Repeatable bool field to ConfigOption to allow multiple inputs. ui: Work with new repeatable input type.

chappjc · 2022-10-19T01:14:20Z

OK on your reviews, @JoeGruffins?

chappjc reviewed Aug 30, 2022

View reviewed changes

client/asset/eth/multirpc.go Outdated Show resolved Hide resolved

chappjc reviewed Aug 30, 2022

View reviewed changes

client/asset/eth/multirpc.go Show resolved Hide resolved

buck54321 force-pushed the ethrpc branch from 95f9c31 to 197120f Compare September 2, 2022 10:45

martonp reviewed Sep 3, 2022

View reviewed changes

chappjc added this to the 0.6/1.0 milestone Sep 6, 2022

buck54321 force-pushed the ethrpc branch from 197120f to 5697edb Compare September 7, 2022 02:59

martonp reviewed Sep 8, 2022

View reviewed changes

buck54321 force-pushed the ethrpc branch from b305f90 to 9ca479d Compare September 10, 2022 03:14

JoeGruffins reviewed Sep 12, 2022

View reviewed changes

chappjc self-requested a review September 12, 2022 12:39

JoeGruffins reviewed Sep 13, 2022

View reviewed changes

JoeGruffins mentioned this pull request Sep 16, 2022

erc20: Add testnet usdc. #1733

Merged

buck54321 force-pushed the ethrpc branch from 9ca479d to 615a560 Compare September 20, 2022 01:21

buck54321 commented Sep 20, 2022

View reviewed changes

buck54321 force-pushed the ethrpc branch from 709c4b6 to 02d3b66 Compare September 21, 2022 06:37

JoeGruffins reviewed Sep 23, 2022

View reviewed changes

JoeGruffins reviewed Sep 26, 2022

View reviewed changes

client/asset/eth/nodeclient_harness_test.go Outdated Show resolved Hide resolved

JoeGruffins approved these changes Sep 26, 2022

View reviewed changes

chappjc reviewed Sep 28, 2022

View reviewed changes

buck54321 force-pushed the ethrpc branch from 93f424f to 177cf09 Compare September 29, 2022 11:36

JoeGruffins reviewed Sep 30, 2022

View reviewed changes

buck54321 force-pushed the ethrpc branch from f088fa6 to 53e6d16 Compare October 3, 2022 21:43

martonp reviewed Oct 6, 2022

View reviewed changes

client/asset/eth/multirpc.go Show resolved Hide resolved

client/asset/eth/multirpc.go Show resolved Hide resolved

client/asset/eth/multirpc.go Outdated Show resolved Hide resolved

buck54321 force-pushed the ethrpc branch from 60b0a32 to 90d7421 Compare October 12, 2022 14:52

chappjc added the ETH label Oct 12, 2022

chappjc reviewed Oct 17, 2022

View reviewed changes

client/asset/eth/eth_test.go Show resolved Hide resolved

chappjc reviewed Oct 17, 2022

View reviewed changes

buck54321 added 17 commits October 18, 2022 07:45

add receipts cache. improved bestHeader handling. e2e tests running

90eb63c

add api compliance validation. docs. fix some tests

06a3ba0

more error control. test new methods. bug fixes.

1766557

martonp early review followup

ef362f9

fix block number parsing

35ade66

handle disabled wallet type

84ba999

use dumb fork choice algo

3f9e0eb

fix receipt cache

b410a24

add receipt cache test

4c511b8

testnet harness working

1824c98

review followup

02d0243

touchups

2cb5ff0

coin not found fixes

4e2a0fd

fix market buy qty. martonp review followup

930215e

clean up commented code. fix rebase whoopsie

55e22eb

eth_test fixes

d8ab7d7

buck54321 force-pushed the ethrpc branch from 90d7421 to d8ab7d7 Compare October 18, 2022 12:48

martonp approved these changes Oct 18, 2022

View reviewed changes

chappjc merged commit 921f7f6 into decred:master Oct 19, 2022

buck54321 mentioned this pull request Jan 6, 2023

eth/testing: personal namespace is deprecated. #2033

Closed

		// failed will be true if setFailed has been called in the last failQuarantine.
		func (p *provider) failed() bool {

		// syncProgress: We're going to lie and just always say we're synced if we
		// can get a header.

client/asset/eth: add RPC client #1832

client/asset/eth: add RPC client #1832

Conversation

buck54321 commented Aug 30, 2022

martonp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

buck54321 commented Sep 7, 2022

martonp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeGruffins left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeGruffins Sep 12, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeGruffins Sep 12, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeGruffins Sep 13, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

buck54321 Sep 18, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeGruffins commented Sep 13, 2022

JoeGruffins commented Sep 13, 2022 • edited Loading

JoeGruffins commented Sep 16, 2022 • edited Loading

Choose a reason for hiding this comment

JoeGruffins commented Sep 21, 2022 • edited Loading

JoeGruffins commented Sep 21, 2022 • edited Loading

buck54321 commented Sep 21, 2022 • edited Loading

buck54321 commented Sep 21, 2022

JoeGruffins commented Sep 21, 2022

Choose a reason for hiding this comment

chappjc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chappjc commented Oct 17, 2022

martonp commented Oct 17, 2022

chappjc commented Oct 19, 2022

JoeGruffins Sep 12, 2022 •

edited

Loading

JoeGruffins Sep 12, 2022 •

edited

Loading

JoeGruffins Sep 13, 2022 •

edited

Loading

buck54321 Sep 18, 2022 •

edited

Loading

JoeGruffins commented Sep 13, 2022 •

edited

Loading

JoeGruffins commented Sep 16, 2022 •

edited

Loading

JoeGruffins commented Sep 21, 2022 •

edited

Loading

JoeGruffins commented Sep 21, 2022 •

edited

Loading

buck54321 commented Sep 21, 2022 •

edited

Loading