Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test-react-app): refactor deprecated call to ReactDOM.render #1418

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

nickreynolds
Copy link
Contributor

What issue is this PR fixing

  • removes an error that can be safely ignored but can cause confusion

What is being changed

  • just refactor how the root of the app is rendered

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because _________, and I am aware that a PR without tests will likely get rejected.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.72%. Comparing base (01de67d) to head (1a0a684).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1418   +/-   ##
=======================================
  Coverage   89.72%   89.72%           
=======================================
  Files         177      177           
  Lines       26818    26818           
  Branches     2220     2220           
=======================================
  Hits        24062    24062           
  Misses       2756     2756           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants