Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unittest fixes, reduce output #446

Merged
merged 16 commits into from
May 20, 2019
Merged

Unittest fixes, reduce output #446

merged 16 commits into from
May 20, 2019

Commits on May 20, 2019

  1. msodde: Ensure OleFileIO is always closed

    @christian-intra2net
    christian-intra2net committed May 20, 2019
    Configuration menu
    Copy the full SHA
    c8acc7a View commit details
    Browse the repository at this point in the history

  2. tests: Fix args for msodde return-code test 

    When adapting the test a while ago, Samir forgot that this one test
tested with multiple args. That was unnecessary, anyway, so removed
them.
    @christian-intra2net
    christian-intra2net committed May 20, 2019
    Configuration menu
    Copy the full SHA
    e250400 View commit details
    Browse the repository at this point in the history

  3. tests: call more top-level function from msodde

    @christian-intra2net
    christian-intra2net committed May 20, 2019
    Configuration menu
    Copy the full SHA
    6b7f267 View commit details
    Browse the repository at this point in the history

  4. tests: Specify exactly what type of error is expected from msodde 

    Prevent unwanted FileNotFoundError caused by wrong test code shadow
actual msodde output
    @christian-intra2net
    christian-intra2net committed May 20, 2019
    Configuration menu
    Copy the full SHA
    6067550 View commit details
    Browse the repository at this point in the history

  5. tests: Reduce text output from oleobj tests 

    Instead of calling main() in current interpreter, fork a new one using
call_and_capture
    @christian-intra2net
    christian-intra2net committed May 20, 2019
    Configuration menu
    Copy the full SHA
    225312a View commit details
    Browse the repository at this point in the history

  6. tests: Reduce output from oleobj tests even further

    @christian-intra2net
    christian-intra2net committed May 20, 2019
    Configuration menu
    Copy the full SHA
    7bdfcf7 View commit details
    Browse the repository at this point in the history

  7. crypto: Ensure ole file is closed

    @christian-intra2net
    christian-intra2net committed May 20, 2019
    Configuration menu
    Copy the full SHA
    8708e4f View commit details
    Browse the repository at this point in the history

  8. ppt_parser: ensure ppt_file is closed

    @christian-intra2net
    christian-intra2net committed May 20, 2019
    Configuration menu
    Copy the full SHA
    af4c3b7 View commit details
    Browse the repository at this point in the history

  9. tests: Replace deprecated function

    @christian-intra2net
    christian-intra2net committed May 20, 2019
    Configuration menu
    Copy the full SHA
    52af455 View commit details
    Browse the repository at this point in the history

  10. xls_parser: close XlsFile after use

    @christian-intra2net
    christian-intra2net committed May 20, 2019
    Configuration menu
    Copy the full SHA
    4b10b95 View commit details
    Browse the repository at this point in the history

  11. xls_parser: no use to treat CryptoError differently

    @christian-intra2net
    christian-intra2net committed May 20, 2019
    Configuration menu
    Copy the full SHA
    2f6fb29 View commit details
    Browse the repository at this point in the history

  12. oleobj: Always close PptFile

    @christian-intra2net
    christian-intra2net committed May 20, 2019
    Configuration menu
    Copy the full SHA
    b52e0e4 View commit details
    Browse the repository at this point in the history

  13. tests: Use call_and_capture to get output from msodde 

    This way, we get the output even in error case to simplify debugging
    @christian-intra2net
    christian-intra2net committed May 20, 2019
    Configuration menu
    Copy the full SHA
    acb05d3 View commit details
    Browse the repository at this point in the history

  14. msodde: ensure XlsFile is always closed

    @christian-intra2net
    christian-intra2net committed May 20, 2019
    Configuration menu
    Copy the full SHA
    a2be569 View commit details
    Browse the repository at this point in the history

  15. tests: Ensure unicode can be printed 

    This is kind of a hack, hope this can be removed once other branch
is merged (see code comment)
    @christian-intra2net
    christian-intra2net committed May 20, 2019
    Configuration menu
    Copy the full SHA
    a825872 View commit details
    Browse the repository at this point in the history

  16. ppt_parser: Accept one more non-standard version

    @christian-intra2net
    christian-intra2net committed May 20, 2019
    Configuration menu
    Copy the full SHA
    f3dbed9 View commit details
    Browse the repository at this point in the history