Refactor/bump node #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-kusnierz
commented
Dec 8, 2023
lib/index.js
Outdated
| @@ -124,3 +124,4 @@ function getSchemaForeignKeys(schemaName, foreignKeys) { | |||
| } | |||
|
|
|||
| module.exports = schemagicInit(); | |||
| module.exports.formats = require('./formats'); | |||
There was a problem hiding this comment.
Added export of formats that was used in other apps through require('schemagic/formats').currency;
m-kusnierz
commented
Dec 8, 2023
Comment on lines
+157
to
+158
| const schemaCopy = clone(schema); | ||
| const schemaTraverse = traverse(schemaCopy); |
There was a problem hiding this comment.
Renamed variables
hilleer
reviewed
Dec 8, 2023
| return callback(null, errors); | ||
| }); | ||
| } | ||
| }; | ||
|
|
||
| function getValuesToCheck(foreignKeys, document) { | ||
| var memo = {}; | ||
| let memo = {}; |
There was a problem hiding this comment.
Do we actually redefine memo or just add properties?
memo.foo = 'foo';does not mean we redefined memo and it can be const in this case
There was a problem hiding this comment.
We do just in the first line of the collapsed code part 😄
hilleer
reviewed
Dec 8, 2023
hilleer
reviewed
Dec 8, 2023
hilleer
approved these changes
Dec 8, 2023
Co-authored-by: Daniel Hillmann <hiller@live.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
libdirectoryexportedSuch export breaks the idea of having only schemas exported.formatsas it seems that they are used by the apps requiring this package